All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	platform-driver-x86@vger.kernel.org
Subject: Re: intel_turbo_max_3 non-modularity
Date: Mon, 24 Apr 2017 10:02:18 -0400	[thread overview]
Message-ID: <20170424140218.GR16239@windriver.com> (raw)
In-Reply-To: <20170424113103.0de3ea31@endymion>

[intel_turbo_max_3 non-modularity] On 24/04/2017 (Mon 11:31) Jean Delvare wrote:

> Hi all,
> 
> I see that the intel_turbo_max_3 driver was originally supposed to be
> modular, and then support for that possibility was removed. Is there
> any fundamental reason why this driver can't be built as a module?

Re-reading the thread, it was stated that the driver needed exports of
some scheduler functions that weren't currently exported.  To me, that
means one of two things -- the driver is poking at scheduler internals
that it shouldn't be and needs to be modified accordingly, or that
someone needs to convince the sched folks that there is valid use cases
for exports of these functions, and _then_ enable modularity.

I didn't try to build it as a module, so I can't say what the sched
dependencies were, or if they looked valid.  But I have seen the sched
folks being not impressed at how certain arch specific PM/freq stuff has
been implemented in the past, which is why I mention it as a possibility.

P.

  reply	other threads:[~2017-04-24 14:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  9:31 intel_turbo_max_3 non-modularity Jean Delvare
2017-04-24 14:02 ` Paul Gortmaker [this message]
2017-04-27 21:48   ` Darren Hart
2017-04-27 23:18     ` Srinivas Pandruvada
2017-04-28  7:55       ` Peter Zijlstra
2017-04-28 13:20         ` Jean Delvare
2017-04-28 13:46           ` Peter Zijlstra
2017-04-28 15:49             ` Darren Hart
2017-04-28 16:34               ` Peter Zijlstra
2017-04-28 20:58                 ` Darren Hart
2017-04-28 21:39                   ` Peter Zijlstra
2017-04-28  8:40       ` Jean Delvare
2017-04-28 20:35         ` Srinivas Pandruvada
2017-04-28  7:49   ` Jean Delvare
2017-04-28 17:44     ` Paul Gortmaker
2017-04-28 20:49       ` Darren Hart
2017-04-28 21:34         ` Peter Zijlstra
2017-04-28 22:51           ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424140218.GR16239@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=jdelvare@suse.de \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.