From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH] iommu: arm-smmu: correct sid to mask Date: Mon, 24 Apr 2017 16:54:54 +0100 Message-ID: <20170424155453.GP12323@arm.com> References: <1492765416-30835-1-git-send-email-peng.fan@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1492765416-30835-1-git-send-email-peng.fan-3arQi8VN3Tc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Peng Fan , joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > From code "SMR mask 0x%x out of range for SMMU", > so, we need to use mask, not sid. > > Signed-off-by: Peng Fan > Cc: Will Deacon > Cc: Robin Murphy > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index b493c99..5a06de2 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev) > } > if (mask & ~smmu->smr_mask_mask) { > dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n", > - sid, smmu->smr_mask_mask); > + mask, smmu->smr_mask_mask); > goto out_free; Looks like a copy-paste error to me: Acked-by: Will Deacon Joerg: do you mind picking this one up, please? Thanks, Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 24 Apr 2017 16:54:54 +0100 Subject: [PATCH] iommu: arm-smmu: correct sid to mask In-Reply-To: <1492765416-30835-1-git-send-email-peng.fan@nxp.com> References: <1492765416-30835-1-git-send-email-peng.fan@nxp.com> Message-ID: <20170424155453.GP12323@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > From code "SMR mask 0x%x out of range for SMMU", > so, we need to use mask, not sid. > > Signed-off-by: Peng Fan > Cc: Will Deacon > Cc: Robin Murphy > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index b493c99..5a06de2 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev) > } > if (mask & ~smmu->smr_mask_mask) { > dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n", > - sid, smmu->smr_mask_mask); > + mask, smmu->smr_mask_mask); > goto out_free; Looks like a copy-paste error to me: Acked-by: Will Deacon Joerg: do you mind picking this one up, please? Thanks, Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S972390AbdDXPzU (ORCPT ); Mon, 24 Apr 2017 11:55:20 -0400 Received: from foss.arm.com ([217.140.101.70]:58392 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S972356AbdDXPyz (ORCPT ); Mon, 24 Apr 2017 11:54:55 -0400 Date: Mon, 24 Apr 2017 16:54:54 +0100 From: Will Deacon To: Peng Fan , joro@8bytes.org Cc: robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu: arm-smmu: correct sid to mask Message-ID: <20170424155453.GP12323@arm.com> References: <1492765416-30835-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492765416-30835-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote: > From code "SMR mask 0x%x out of range for SMMU", > so, we need to use mask, not sid. > > Signed-off-by: Peng Fan > Cc: Will Deacon > Cc: Robin Murphy > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index b493c99..5a06de2 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev) > } > if (mask & ~smmu->smr_mask_mask) { > dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n", > - sid, smmu->smr_mask_mask); > + mask, smmu->smr_mask_mask); > goto out_free; Looks like a copy-paste error to me: Acked-by: Will Deacon Joerg: do you mind picking this one up, please? Thanks, Will