Re: [morty PATCH v2 1/3] ti-cgt-arm: add recipe for 16.9.2

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Apr 24, 2017 at 06:37:41PM +0530, Karthik Ramanan wrote:
> Jake, Denys - some questions for you.
> 
> >> +PV = "16.9.2"
> > Would it be better to have this in the recipe filename? I'm not
> sure if there is a preference.
> Denys, what is the recommendation? I see both approaches, I can
> rework and submit if the PV should be included in the filename.

Depends on how often you plan to update the recipe and whether you will have 
between-releases snapshots. That's usually the case with git-based components. 
In case of tarball or binary-installer components, the convention is to use 
the version in the filename.


> >> +BBCLASSEXTEND = "native nativesdk"
> > It appears that there is not support for the "target" class as the
> installer is for the x86 architecture.
> Just to be clear, would it be fine to just remove the nativesdk?

Are there plans to have ARM installer? If not, then "target" recipe with 
BBCLASSEXTEND won't work - you just need to do a -native recipe directly.

-- 
Denys


> On 21-Apr-17 8:02 PM, Jacob Stiffler wrote:
> >Karthik,
> >
> >A couple concerns below.
> >
> >Thanks,
> >
> >Jake
> >
> >
> >On 4/21/2017 10:15 AM, Karthik Ramanan wrote:
> >>Signed-off-by: Karthik Ramanan <a0393906@ti.com>
> >>---
> >>  recipes-ti/devtools/ti-cgt-arm.bb  |  8 ++++++++
> >>  recipes-ti/devtools/ti-cgt-arm.inc | 36
> >>++++++++++++++++++++++++++++++++++++
> >>  2 files changed, 44 insertions(+)
> >>  create mode 100644 recipes-ti/devtools/ti-cgt-arm.bb
> >>  create mode 100644 recipes-ti/devtools/ti-cgt-arm.inc
> >>
> >>diff --git a/recipes-ti/devtools/ti-cgt-arm.bb
> >>b/recipes-ti/devtools/ti-cgt-arm.bb
> >>new file mode 100644
> >>index 0000000..82c1903
> >>--- /dev/null
> >>+++ b/recipes-ti/devtools/ti-cgt-arm.bb
> >>@@ -0,0 +1,8 @@
> >>+include ti-cgt-arm.inc
> >>+
> >>+LIC_FILES_CHKSUM = "file://${PN}_${PV}.LTS/README.txt;md5=c32eadd03472353c042a8a7c4568438b"
> >>+
> >>+PV = "16.9.2"
> >
> >Would it be better to have this in the recipe filename? I'm not
> >sure if there is a preference.
> >
> >>+
> >>+BINFILE_MD5 = "7b73e51e9548a4a0bf3923a336b1a974"
> >>+BINFILE_SHA256 =
> >>"d1a5c255319088be7d75b3fce1b16a2e3d60c75023db7dad16cab6d4d3425d06"
> >>diff --git a/recipes-ti/devtools/ti-cgt-arm.inc
> >>b/recipes-ti/devtools/ti-cgt-arm.inc
> >>new file mode 100644
> >>index 0000000..3897b2e
> >>--- /dev/null
> >>+++ b/recipes-ti/devtools/ti-cgt-arm.inc
> >>@@ -0,0 +1,36 @@
> >>+SUMMARY= "TI ARM Code Generation Tools"
> >>+HOMEPAGE = "https://www-a.ti.com/downloads/sds_support/TICodegenerationTools/download.htm"
> >>+LICENSE = "(TI-TSPA & Thai-Open-Source-Software-Center) &
> >>BSD-3-Clause & BSL-1.0 & Hewlett-Packard & AFL-3.0 & MIT &
> >>BSD-2-Clause & PD & BSD-4-Clause"
> >>+
> >>+require recipes-ti/includes/ti-unpack.inc
> >>+require recipes-ti/includes/ti-staging.inc
> >>+require recipes-ti/includes/ti-paths.inc
> >>+
> >>+S = "${WORKDIR}/ti-cgt-arm-${PV}"
> >>+
> >>+SRC_URI = "http://software-dl.ti.com/codegen/esd/cgt_public_sw/TMS470/${PV}.LTS/${BINFILE};name=${BINFILE_NAME}"
> >>+
> >>+BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin"
> >>+TI_BIN_UNPK_ARGS = "--prefix ${S}"
> >>+TI_BIN_UNPK_CMDS = ""
> >>+
> >>+do_install() {
> >>+    install -d ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}
> >>+    cp -r ${S}/ti-cgt-arm*/. ${D}${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}
> >>+}
> >>+
> >>+SRC_URI[cgt_arm_installer.md5sum] = "${BINFILE_MD5}"
> >>+SRC_URI[cgt_arm_installer.sha256sum] = "${BINFILE_SHA256}"
> >>+
> >>+BINFILE_NAME = "cgt_arm_installer"
> >>+BINFILE = "ti_cgt_tms470_${PV}.LTS_linux_installer_x86.bin"
> >>+
> >>+FILES_${PN} += "${M4_TOOLCHAIN_INSTALL_DIR_RECIPE}"
> >>+
> >>+BBCLASSEXTEND = "native nativesdk"
> >
> >It appears that there is not support for the "target" class as the
> >installer is for the x86 architecture.
> >
> >>+
> >>+INHIBIT_PACKAGE_STRIP = "1"
> >>+INHIBIT_SYSROOT_STRIP = "1"
> >>+INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> >>+
> >>+INSANE_SKIP_${PN} += "arch staticdev"
> >
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti