From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] crypto: move 'opaque' parameter to (nearly) the end of parameter list
Date: Tue, 25 Apr 2017 10:00:36 +0800 [thread overview]
Message-ID: <20170425020036.GC13555@lemon.lan> (raw)
In-Reply-To: <20170424153615.18614-1-berrange@redhat.com>
On Mon, 04/24 16:36, Daniel P. Berrange wrote:
> Previous commit moved 'opaque' to be the 2nd parameter in the list:
>
> commit 375092332eeaa6e47561ce47fd36144cdaf964d0
> Author: Fam Zheng <famz@redhat.com>
> Date: Fri Apr 21 20:27:02 2017 +0800
>
> crypto: Make errp the last parameter of functions
>
> Move opaque to 2nd instead of the 2nd to last, so that compilers help
> check with the conversion.
>
> this puts it back to the 2nd to last position.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-04-25 2:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 15:36 [Qemu-devel] [PATCH] crypto: move 'opaque' parameter to (nearly) the end of parameter list Daniel P. Berrange
2017-04-24 15:46 ` Eric Blake
2017-04-25 2:00 ` Fam Zheng [this message]
2017-04-25 7:30 ` Markus Armbruster
2017-04-25 9:06 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425020036.GC13555@lemon.lan \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.