From: Pablo Neira Ayuso <pablo@netfilter.org>
To: gfree.wind@foxmail.com
Cc: netfilter-devel@vger.kernel.org, Gao Feng <fgao@ikuai8.com>,
Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf v3] netfilter: xt_CT: fix refcnt leak on error path
Date: Tue, 25 Apr 2017 11:05:18 +0200 [thread overview]
Message-ID: <20170425090518.GA2833@salvia> (raw)
In-Reply-To: <1492135208-52964-1-git-send-email-gfree.wind@foxmail.com>
On Fri, Apr 14, 2017 at 10:00:08AM +0800, gfree.wind@foxmail.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> There are two cases which causes refcnt leak.
>
> 1. When nf_ct_timeout_ext_add failed in xt_ct_set_timeout, it should
> free the timeout refcnt.
> Now goto the err_put_timeout error handler instead of going ahead.
>
> 2. When the time policy is not found, we should call module_put.
> Otherwise, the related cthelper module cannot be removed anymore.
> It is easy to reproduce by typing the following command:
> # iptables -t raw -A OUTPUT -p tcp -j CT --helper ftp --timeout xxx
Applied, thanks.
prev parent reply other threads:[~2017-04-25 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 2:00 [PATCH nf v3] netfilter: xt_CT: fix refcnt leak on error path gfree.wind
2017-04-25 9:05 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425090518.GA2833@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@foxmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.