From: Steffen Klassert <steffen.klassert@secunet.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] esp4: Reorganize esp_output
Date: Tue, 25 Apr 2017 09:31:45 +0000 [thread overview]
Message-ID: <20170425093145.GR2649@secunet.com> (raw)
In-Reply-To: <20170421204932.kuy6c2ivmqn7dk65@mwanda>
On Mon, Apr 24, 2017 at 09:48:12AM +0200, Steffen Klassert wrote:
> On Fri, Apr 21, 2017 at 11:49:32PM +0300, Dan Carpenter wrote:
> > Hello Steffen Klassert,
>
> I plan to fix this with the patch below:
>
> Subject: [PATCH] esp: Fix misplaced spin_unlock_bh.
>
> A recent commit moved esp_alloc_tmp() out of a lock
> protected region, but forgot to remove the unlock from
> the error path. This patch removes the forgotten unlock.
> While at it, remove some unneeded error assignments too.
>
> Fixes: fca11ebde3f0 ("esp4: Reorganize esp_output")
> Fixes: 383d0350f2cc ("esp6: Reorganize esp_output")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
I've applied this to ipsec-next now, thanks for the report!
prev parent reply other threads:[~2017-04-25 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 20:49 [bug report] esp4: Reorganize esp_output Dan Carpenter
2017-04-24 7:48 ` Steffen Klassert
2017-04-25 9:31 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425093145.GR2649@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.