All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Marc Ferland <ferlandm@amotus.ca>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCHv4 4/7] bluez5: add PACKAGECONFIG option for systemd
Date: Tue, 25 Apr 2017 17:13:50 +0200	[thread overview]
Message-ID: <20170425151350.GC28641@jama> (raw)
In-Reply-To: <1493131720-19456-5-git-send-email-ferlandm@amotus.ca>

[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]

On Tue, Apr 25, 2017 at 10:48:37AM -0400, Marc Ferland wrote:
> Signed-off-by: Marc Ferland <ferlandm@amotus.ca>
> ---
>  meta/recipes-connectivity/bluez5/bluez5.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 687656e..71a5016 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -12,11 +12,12 @@ RPROVIDES_${PN} += "bluez-hcidump"
>  
>  RCONFLICTS_${PN} = "bluez4"
>  
> -PACKAGECONFIG ??= "obex-profiles readline"
> +PACKAGECONFIG ??= "obex-profiles readline ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
>  PACKAGECONFIG[obex-profiles] = "--enable-obex,--disable-obex,libical"
>  PACKAGECONFIG[readline] = "--enable-client,--disable-client,readline,"
>  PACKAGECONFIG[testing] = "--enable-testing,--disable-testing"
>  PACKAGECONFIG[midi] = "--enable-midi,--disable-midi,alsa-lib"
> +PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd"
>  
>  SRC_URI = "\
>      ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> @@ -36,7 +37,6 @@ EXTRA_OECONF = "\
>    --disable-cups \
>    --enable-test \
>    --enable-datafiles \
> -  ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--enable-systemd', '--disable-systemd', d)} \

Why not use just the options from PACKAGECONFIG?

>    --enable-library \
>  "
>  
> -- 
> 2.7.4
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

  reply	other threads:[~2017-04-25 15:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 14:48 [PATCHv4 0/7] bluez: upgrade and refactoring Marc Ferland
2017-04-25 14:48 ` [PATCHv4 1/7] bluez5: Upgrade 5.43 -> 5.44 Marc Ferland
2017-04-25 14:48 ` [PATCHv4 2/7] bluez5: remove libasound-module references Marc Ferland
2017-04-25 14:48 ` [PATCHv4 3/7] bluez5: add PACKAGECONFIG option for midi Marc Ferland
2017-04-25 14:48 ` [PATCHv4 4/7] bluez5: add PACKAGECONFIG option for systemd Marc Ferland
2017-04-25 15:13   ` Martin Jansa [this message]
2017-04-25 16:30     ` Marc Ferland
2017-04-25 14:48 ` [PATCHv4 5/7] bluez5: add PACKAGECONFIG option for cups Marc Ferland
2017-04-25 14:48 ` [PATCHv4 6/7] bluez5: do not install audio.conf Marc Ferland
2017-04-25 14:48 ` [PATCHv4 7/7] bluez5: cleanup tabs and spaces Marc Ferland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170425151350.GC28641@jama \
    --to=martin.jansa@gmail.com \
    --cc=ferlandm@amotus.ca \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.