From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: ulrik.debie-os@e2big.org
Cc: Julian Exner <jexner@techfak.uni-bielefeld.de>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
aduggan@synaptics.com
Subject: Re: Input: mouse: Trackpoint middle button not recognized on Thinkpad E470
Date: Tue, 25 Apr 2017 15:10:14 -0700 [thread overview]
Message-ID: <20170425221014.GD30843@dtor-ws> (raw)
In-Reply-To: <20170425211633.bl72ajw5duwdpq4j@beacon.debie>
On Tue, Apr 25, 2017 at 11:16:33PM +0200, ulrik.debie-os@e2big.org wrote:
> Hi Julian, Dmitry,
>
> I have a similar behaviour for thinkpad e570 trackpoint. Manually forcing
> button_info also made the middle button work.
> Julian, I planned to go the investigation road just when I happened to see
> your email.
>
> Dmitry, what do you suggest as a path forward when
> extended-button-data command fails ? Check for DMI and whitelist 3button
> for certain laptops which will be a growing list (2 laptops known already)?
> Default to 3 buttons when extended-button-data command fails ?
Hmm.. I do not recall seeing real trackpoints with only 2 buttons. Let's
try defaulting to 3 and see what happens.
>
> Julian, feel free to propose a patch, I'll review and test on E570.
>
> Kind regards,
> Ulrik
>
>
>
> On Tue, Apr 25, 2017 at 10:06:56PM +0200, Julian Exner wrote:
> > Date: Tue, 25 Apr 2017 22:06:56 +0200
> > From: Julian Exner <jexner@techfak.uni-bielefeld.de>
> > To: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
> > Cc: aduggan@synaptics.com
> > Subject: Re: Input: mouse: Trackpoint middle button not recognized on
> > Thinkpad E470
> > X-Mailing-List: linux-input@vger.kernel.org
> >
> > I checked the Trackpoint specification [1] and apparently 0xFE stands for
> > the Trackpoint controller asking to resend the command due to invalid input.
> > Resending the extended-button-data command results in 0xFC which stands for
> > another invalid input. But 0xFE does not only stand for a resend request but
> > might also mean that the issued command is not implemented in the ROM. [2]
> >
> > So maybe when the extended-button-data command is not support, we can check
> > for certain Trackpoint or ROM ids to deduce if a middle button is present.
> > If you think this is the right approach I may craft a patch for this.
> >
> > [1] http://blogs.epfl.ch/icenet/documents/Ykt3Eext.pdf
> > [2] http://blogs.epfl.ch/icenet/documents/Ykt3Eext.pdf#page=20
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-input" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Dmitry
next prev parent reply other threads:[~2017-04-25 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 11:36 Input: mouse: Trackpoint middle button not recognized on Thinkpad E470 Julian Exner
2017-04-25 20:06 ` Julian Exner
2017-04-25 21:16 ` ulrik.debie-os
2017-04-25 22:10 ` Dmitry Torokhov [this message]
2017-04-26 21:18 ` Julian Exner
2017-04-28 21:05 ` ulrik.debie-os
2017-05-31 19:13 ` ulrik.debie-os
2017-06-06 18:09 ` Julian Exner
2017-06-06 23:22 ` Peter Hutterer
2017-06-15 19:51 ` ulrik.debie-os
-- strict thread matches above, loose matches on Subject: below --
2017-05-31 21:02 Oscar Campos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425221014.GD30843@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=jexner@techfak.uni-bielefeld.de \
--cc=linux-input@vger.kernel.org \
--cc=ulrik.debie-os@e2big.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.