All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonsoo Kim <js1304@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH v4 2/4] zram: implement deduplication in zram
Date: Wed, 26 Apr 2017 14:59:31 +0900	[thread overview]
Message-ID: <20170426055929.GB29773@js1304-desktop> (raw)
In-Reply-To: <20170426023718.GB673@jagdpanzerIV.localdomain>

On Wed, Apr 26, 2017 at 11:37:18AM +0900, Sergey Senozhatsky wrote:
> On (04/26/17 09:52), js1304@gmail.com wrote:
> [..]
> >  struct zram_entry {
> > +	struct rb_node rb_node;
> > +	u32 len;
> > +	u32 checksum;
> > +	unsigned long refcount;
> 
> 	use refcount_t? what do you think?

We don't need atomic operation for refcount but refcount_t does.
API of refcount_t provides additional guarantee that refcount will not
overflow but I'm not sure that this overhead is needed here.

Thanks.

  reply	other threads:[~2017-04-26  6:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  0:52 [PATCH v4 0/4] zram: implement deduplication in zram js1304
2017-04-26  0:52 ` [PATCH v4 1/4] zram: introduce zram_entry to prepare dedup functionality js1304
2017-04-26  0:52 ` [PATCH v4 2/4] zram: implement deduplication in zram js1304
2017-04-26  2:14   ` Sergey Senozhatsky
2017-04-26  5:57     ` Joonsoo Kim
2017-04-26  6:29       ` Minchan Kim
2017-04-26  6:59         ` Joonsoo Kim
2017-04-26  7:21           ` Sergey Senozhatsky
2017-04-26  7:39             ` Minchan Kim
2017-04-26  7:12         ` Sergey Senozhatsky
2017-04-26  2:37   ` Sergey Senozhatsky
2017-04-26  5:59     ` Joonsoo Kim [this message]
2017-04-26  6:04       ` Sergey Senozhatsky
2017-04-26  4:02   ` Sergey Senozhatsky
2017-04-26  6:04     ` Joonsoo Kim
2017-04-26  6:21       ` Sergey Senozhatsky
2017-04-27  6:57         ` Joonsoo Kim
2017-04-27  7:46           ` Sergey Senozhatsky
2017-05-02  5:31             ` Joonsoo Kim
2017-04-26  4:28   ` Sergey Senozhatsky
2017-04-26  6:08     ` Joonsoo Kim
2017-04-26  6:14       ` Sergey Senozhatsky
2017-04-26  0:52 ` [PATCH v4 3/4] zram: make deduplication feature optional js1304
2017-04-26  0:52 ` [PATCH v4 4/4] zram: compare all the entries with same checksum for deduplication js1304
2017-04-27  7:49 ` [PATCH v4 0/4] zram: implement deduplication in zram Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426055929.GB29773@js1304-desktop \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.