From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 02/21] libiscsi: Add an internal error code Date: Wed, 26 Apr 2017 09:48:48 +0200 Message-ID: <20170426074848.GA8081@lst.de> References: <1493144468-22493-1-git-send-email-logang@deltatee.com> <1493144468-22493-3-git-send-email-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1493144468-22493-3-git-send-email-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Logan Gunthorpe Cc: dri-devel@lists.freedesktop.org, Stephen Bates , dm-devel@redhat.com, target-devel@vger.kernel.org, Christoph Hellwig , devel@driverdev.osuosl.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, Sumit Semwal , Ross Zwisler , open-iscsi@googlegroups.com, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, sparmaintainer@unisys.com, linux-raid@vger.kernel.org, Dan Williams , megaraidlinux.pdl@broadcom.com, Jens Axboe , "Martin K. Petersen" , netdev@vger.kernel.org, Matthew Wilcox , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Greg Kroah-Hartman List-Id: dm-devel.ids T24gVHVlLCBBcHIgMjUsIDIwMTcgYXQgMTI6MjA6NDlQTSAtMDYwMCwgTG9nYW4gR3VudGhvcnBl IHdyb3RlOgo+IFRoaXMgaXMgYSBwcmVwIHBhdGNoIHRvIGFkZCBhIG5ldyBlcnJvciBjb2RlIHRv IGxpYmlzY3NpLiBXZSB3YW50IHRvCj4gcmV3b3JrIHNvbWUga21hcCBjYWxscyB0byBiZSBhYmxl IHRvIGZhaWwuIFdoZW4gd2UgZG8sIHdlJ2QgbGlrZSB0bwo+IHVzZSB0aGlzIGVycm9yIGNvZGUu CgpUaGUga21hcCBjYXNlIGluIGlzY3NpX3RjcF9zZWdtZW50X21hcCBjYW4gYWxyZWFkeSBmYWls LiAgUGxlYXNlIGFkZApoYW5kbGluZyBvZiB0aGF0IGZhaWx1cmUgdG8gdGhpcyBwYXRjaCwgYW5k IHdlIHNob3VsZCBnZXQgaXQgbWVyZ2VkCkFTQVAuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 02/21] libiscsi: Add an internal error code Date: Wed, 26 Apr 2017 09:48:48 +0200 Message-ID: <20170426074848.GA8081@lst.de> References: <1493144468-22493-1-git-send-email-logang@deltatee.com> <1493144468-22493-3-git-send-email-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dri-devel@lists.freedesktop.org, Stephen Bates , dm-devel@redhat.com, target-devel@vger.kernel.org, Christoph Hellwig , devel@driverdev.osuosl.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, Sumit Semwal , Ross Zwisler , open-iscsi@googlegroups.com, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, sparmaintainer@unisys.com, linux-raid@vger.kernel.org, Dan Williams , megaraidlinux.pdl@broadcom.com, Jens Axboe , "Martin K. Petersen" , netdev@vger.kernel.org, Matthew Wilcox , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Greg Kroah-Hartman Return-path: Content-Disposition: inline In-Reply-To: <1493144468-22493-3-git-send-email-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" List-Id: linux-crypto.vger.kernel.org T24gVHVlLCBBcHIgMjUsIDIwMTcgYXQgMTI6MjA6NDlQTSAtMDYwMCwgTG9nYW4gR3VudGhvcnBl IHdyb3RlOgo+IFRoaXMgaXMgYSBwcmVwIHBhdGNoIHRvIGFkZCBhIG5ldyBlcnJvciBjb2RlIHRv IGxpYmlzY3NpLiBXZSB3YW50IHRvCj4gcmV3b3JrIHNvbWUga21hcCBjYWxscyB0byBiZSBhYmxl IHRvIGZhaWwuIFdoZW4gd2UgZG8sIHdlJ2QgbGlrZSB0bwo+IHVzZSB0aGlzIGVycm9yIGNvZGUu CgpUaGUga21hcCBjYXNlIGluIGlzY3NpX3RjcF9zZWdtZW50X21hcCBjYW4gYWxyZWFkeSBmYWls LiAgUGxlYXNlIGFkZApoYW5kbGluZyBvZiB0aGF0IGZhaWx1cmUgdG8gdGhpcyBwYXRjaCwgYW5k IHdlIHNob3VsZCBnZXQgaXQgbWVyZ2VkCkFTQVAuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 35E3821954068 for ; Wed, 26 Apr 2017 00:48:51 -0700 (PDT) Date: Wed, 26 Apr 2017 09:48:48 +0200 From: Christoph Hellwig Subject: Re: [PATCH v2 02/21] libiscsi: Add an internal error code Message-ID: <20170426074848.GA8081@lst.de> References: <1493144468-22493-1-git-send-email-logang@deltatee.com> <1493144468-22493-3-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1493144468-22493-3-git-send-email-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: dri-devel@lists.freedesktop.org, dm-devel@redhat.com, target-devel@vger.kernel.org, Christoph Hellwig , devel@driverdev.osuosl.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, Sumit Semwal , open-iscsi@googlegroups.com, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, sparmaintainer@unisys.com, linux-raid@vger.kernel.org, megaraidlinux.pdl@broadcom.com, Jens Axboe , "Martin K. Petersen" , netdev@vger.kernel.org, Matthew Wilcox , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Greg Kroah-Hartman List-ID: On Tue, Apr 25, 2017 at 12:20:49PM -0600, Logan Gunthorpe wrote: > This is a prep patch to add a new error code to libiscsi. We want to > rework some kmap calls to be able to fail. When we do, we'd like to > use this error code. The kmap case in iscsi_tcp_segment_map can already fail. Please add handling of that failure to this patch, and we should get it merged ASAP. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from verein.lst.de ([213.95.11.211]:39391 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1956546AbdDZHsw (ORCPT ); Wed, 26 Apr 2017 03:48:52 -0400 Date: Wed, 26 Apr 2017 09:48:48 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-nvdimm@lists.01.org, linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com, megaraidlinux.pdl@broadcom.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, target-devel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Jens Axboe , Greg Kroah-Hartman , Dan Williams , Ross Zwisler , Matthew Wilcox , Sumit Semwal , Stephen Bates Subject: Re: [PATCH v2 02/21] libiscsi: Add an internal error code Message-ID: <20170426074848.GA8081@lst.de> References: <1493144468-22493-1-git-send-email-logang@deltatee.com> <1493144468-22493-3-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493144468-22493-3-git-send-email-logang@deltatee.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Tue, Apr 25, 2017 at 12:20:49PM -0600, Logan Gunthorpe wrote: > This is a prep patch to add a new error code to libiscsi. We want to > rework some kmap calls to be able to fail. When we do, we'd like to > use this error code. The kmap case in iscsi_tcp_segment_map can already fail. Please add handling of that failure to this patch, and we should get it merged ASAP. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1435412AbdDZHtR (ORCPT ); Wed, 26 Apr 2017 03:49:17 -0400 Received: from verein.lst.de ([213.95.11.211]:39391 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1956546AbdDZHsw (ORCPT ); Wed, 26 Apr 2017 03:48:52 -0400 Date: Wed, 26 Apr 2017 09:48:48 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com, megaraidlinux.pdl@broadcom.com, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, target-devel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Jens Axboe , Greg Kroah-Hartman , Dan Williams , Ross Zwisler , Matthew Wilcox , Sumit Semwal , Stephen Bates Subject: Re: [PATCH v2 02/21] libiscsi: Add an internal error code Message-ID: <20170426074848.GA8081@lst.de> References: <1493144468-22493-1-git-send-email-logang@deltatee.com> <1493144468-22493-3-git-send-email-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493144468-22493-3-git-send-email-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 12:20:49PM -0600, Logan Gunthorpe wrote: > This is a prep patch to add a new error code to libiscsi. We want to > rework some kmap calls to be able to fail. When we do, we'd like to > use this error code. The kmap case in iscsi_tcp_segment_map can already fail. Please add handling of that failure to this patch, and we should get it merged ASAP.