From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40816 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2997142AbdDZJ2L (ORCPT ); Wed, 26 Apr 2017 05:28:11 -0400 Date: Wed, 26 Apr 2017 11:28:03 +0200 From: Greg Kroah-Hartman To: Maksim Salau Cc: Juergen Stuber , legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org, Alfredo Rafael Vicente Boix , stable@vger.kernel.org Subject: Re: [PATCH v2] usb: misc: legousbtower: Fix buffers on stack Message-ID: <20170426092803.GA20661@kroah.com> References: <20170422162437.6420-1-maksim.salau@gmail.com> <20170425180424.GA899@kroah.com> <20170425222842.60efc758@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425222842.60efc758@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Apr 25, 2017 at 10:28:42PM +0300, Maksim Salau wrote: > On Tue, 25 Apr 2017 20:04:24 +0200 > Greg Kroah-Hartman wrote: > > > On Sat, Apr 22, 2017 at 07:24:37PM +0300, Maksim Salau wrote: > > > Allocate buffers on HEAP instead of STACK for local structures > > > that are to be received using usb_control_msg(). > > > > > > Signed-off-by: Maksim Salau > > > Tested-by: Alfredo Rafael Vicente Boix > > > Cc: stable@vger.kernel.org > > > > This patch does not apply to usb-next, what did you make it against? > > > > Can you rebase it and resend? > > > > thanks, > > > > greg k-h > > Hi Greg, > > I've created the patch against linux-stable v4.10.12. I've checked history > of the driver and it turns out that the patch conflicts with > 9b181166f17534a82b4b628b13e524a893715dfc > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/legousbtower.c?h=usb-next&id=9b181166f17534a82b4b628b13e524a893715dfc > > There are no conflicting changes, but context has changed. > I'll rebase and resend shortly. > > The same patch can't be used for stable and for usb-next anymore. Is there > any chance to backport the fix for stable? Yes, we can backport it, I'll mark it for stable and do the backport when it hits Linus's tree after 4.12-rc1 is out. thanks, greg k-h