From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1957149AbdDZJrh (ORCPT ); Wed, 26 Apr 2017 05:47:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40824 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2996613AbdDZJ3Y (ORCPT ); Wed, 26 Apr 2017 05:29:24 -0400 Date: Wed, 26 Apr 2017 11:29:13 +0200 From: Greg Kroah-Hartman To: Maksim Salau Cc: Juergen Stuber , legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Alfredo Rafael Vicente Boix Subject: Re: [PATCH v3] usb: misc: legousbtower: Fix buffers on stack Message-ID: <20170426092913.GA21563@kroah.com> References: <20170425222842.60efc758@gmail.com> <20170425194921.29548-1-maksim.salau@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425194921.29548-1-maksim.salau@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 10:49:21PM +0300, Maksim Salau wrote: > Allocate buffers on HEAP instead of STACK for local structures > that are to be received using usb_control_msg(). > > Signed-off-by: Maksim Salau > Tested-by: Alfredo Rafael Vicente Boix ; > Cc: stable > > --- > Changes in v3: > * rebased against usb-next; > * removed Tested-by: Alfredo Rafael Vicente Boix ; I added this back, as it matters, and your change from the previous version was trivial. > * removed Cc: stable@vger.kernel.org > since this patch doesn't apply against v4.10.12 I added this back as well :) thanks, greg k-h