All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, thuth@redhat.com
Subject: [Qemu-devel] [PULL 2/5] monitor: Check whether TCG is enabled before running the "info jit" code
Date: Wed, 26 Apr 2017 14:57:04 +0100	[thread overview]
Message-ID: <20170426135707.5261-3-dgilbert@redhat.com> (raw)
In-Reply-To: <20170426135707.5261-1-dgilbert@redhat.com>

From: Thomas Huth <thuth@redhat.com>

The "info jit" command currently aborts on Mac OS X with the message
"qemu_mutex_lock: Invalid argument" when running with "-M accel=qtest".
We should only call into the TCG code here if TCG has really been
enabled and initialized.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1493179907-22516-1-git-send-email-thuth@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Tested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 monitor.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/monitor.c b/monitor.c
index a27dc8003f..6289e5256c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1086,6 +1086,11 @@ static void hmp_info_registers(Monitor *mon, const QDict *qdict)
 
 static void hmp_info_jit(Monitor *mon, const QDict *qdict)
 {
+    if (!tcg_enabled()) {
+        error_report("JIT information is only available with accel=tcg");
+        return;
+    }
+
     dump_exec_info((FILE *)mon, monitor_fprintf);
     dump_drift_info((FILE *)mon, monitor_fprintf);
 }
-- 
2.12.2

  parent reply	other threads:[~2017-04-26 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 13:57 [Qemu-devel] [PULL 0/5] hmp queue Dr. David Alan Gilbert (git)
2017-04-26 13:57 ` [Qemu-devel] [PULL 1/5] hmp: gpa2hva and gpa2hpa hostaddr command Dr. David Alan Gilbert (git)
2017-04-26 13:57 ` Dr. David Alan Gilbert (git) [this message]
2017-04-26 13:57 ` [Qemu-devel] [PULL 3/5] libqtest: Ignore QMP events when parsing the response for HMP commands Dr. David Alan Gilbert (git)
2017-04-26 13:57 ` [Qemu-devel] [PULL 4/5] libqtest: Add a generic function to run a callback function for every machine Dr. David Alan Gilbert (git)
2017-04-26 13:57 ` [Qemu-devel] [PULL 5/5] tests: Add a tester for HMP commands Dr. David Alan Gilbert (git)
2017-04-26 15:08 ` [Qemu-devel] [PULL 0/5] hmp queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426135707.5261-3-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.