From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] usb: chipidea: set dma_ops for the created ci_hdrc platform_device
Date: Wed, 26 Apr 2017 16:41:02 +0800 [thread overview]
Message-ID: <20170426164102.5bd1a48b@xhacker> (raw)
In-Reply-To: <CAK8P3a09fJCexChnoEyBpLK17rHaQTz9G+7iZWRocZGykyxsWA@mail.gmail.com>
On Tue, 25 Apr 2017 13:09:27 +0200 Arnd Bergmann wrote:
> On Tue, Apr 25, 2017 at 12:01 PM, Jisheng Zhang <jszhang@marvell.com> wrote:
> > Hi all,
> >
> > After commit 1dccb598df549 ("arm64: simplify dma_get_ops"), the chipidea
> > driver can't work any more on Marvell Berlin arm64 platforms, the reason
> > is the created ci_hdrc platform_device's dma_ops is dummy_dma_ops, so all
> > dma related operations will fail. The fix I can think of would be something
> > as below:
> >
> > And I noticed that dwc3 has the same issue[1], and as pointed out in its
> > discussion, the patch can't fix None-DT platforms, so could you please
> > guide me what's the proper fix which can be mainlined?
>
> I think the right solution is:
>
> - Set the "sysdev" pointer tin the USB device o the device structure that
> was created by DT or the legacy board file and remove the manual
> setting of dma_mask, parms and the dma_configure. This should
> make everything work as expected in case of DT
>
oh yeah! I see a proper fix in linux-next tree, thanks for fixing it.
prev parent reply other threads:[~2017-04-26 8:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 10:01 [RFC] usb: chipidea: set dma_ops for the created ci_hdrc platform_device Jisheng Zhang
2017-04-25 11:09 ` Arnd Bergmann
2017-04-26 8:41 ` Jisheng Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426164102.5bd1a48b@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.