From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting
Date: Wed, 26 Apr 2017 18:11:10 +0300 [thread overview]
Message-ID: <20170426181041-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36511AC38C@SHSMSX103.ccr.corp.intel.com>
On Wed, Apr 26, 2017 at 05:44:05AM +0000, Tan, Jianfeng wrote:
>
>
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > Sent: Wednesday, April 26, 2017 1:33 PM
> > To: Tan, Jianfeng
> > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; thomas@monjalon.net
> > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting
> >
> > On Wed, Apr 26, 2017 at 04:52:50AM +0000, Jianfeng Tan wrote:
> > > Clean up LSC setting:
> >
> > Firstly, this patch does two things. There should be two patches.
>
> I just merged them into one to adapt to the name of "clean up" :-)
>
> >
> > > - LSC flag is set in several places, but only the last one takes
> > > effect; so we just keep the last one.
> > > - As we already change to use capability list to detect MSI-X, remove
> > > the redundant MSI-X detection in legacy devices.
> >
> > However, there is no capability list for legacy device.
>
> When I try legacy device on QEMU (disable-modern=true), I did detect MSI-X capability. So does virtio spec mean legacy devices do not have vendor-specific capability list?
>
> Thanks,
> Jianfeng
Yes, as far as I know legacy devices don't have vendor-specific
capability lists.
--
MST
next prev parent reply other threads:[~2017-04-26 15:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 4:52 [PATCH 0/3] Some fixes on virtio LSC Jianfeng Tan
2017-04-26 4:52 ` [PATCH 1/3] net/virtio: fix wrong MSI-X for modern devices Jianfeng Tan
2017-04-26 4:52 ` [PATCH 2/3] net/virtio: clean up LSC setting Jianfeng Tan
2017-04-26 5:32 ` Yuanhan Liu
2017-04-26 5:44 ` Tan, Jianfeng
2017-04-26 5:52 ` Yuanhan Liu
2017-04-26 6:00 ` Tan, Jianfeng
2017-04-26 15:11 ` Michael S. Tsirkin [this message]
2017-04-27 7:34 ` Tan, Jianfeng
2017-04-26 4:52 ` [PATCH 3/3] net/virtio: fix link status always being down Jianfeng Tan
2017-04-27 7:35 ` [PATCH v2 0/4] fixes and cleanup on virtio LSC Jianfeng Tan
2017-04-27 7:35 ` [PATCH v2 1/4] net/virtio: fix wrong MSI-X for modern devices Jianfeng Tan
2017-04-27 7:35 ` [PATCH v2 2/4] net/virtio: clean up LSC setting Jianfeng Tan
2017-04-27 7:49 ` Yuanhan Liu
2017-04-28 4:48 ` Yuanhan Liu
2017-04-27 7:35 ` [PATCH v2 3/4] net/virtio: remove redundant MSI-X detection Jianfeng Tan
2017-04-27 7:35 ` [PATCH v2 4/4] net/virtio: fix link status always being down Jianfeng Tan
2017-04-28 4:41 ` [PATCH v2 0/4] fixes and cleanup on virtio LSC Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426181041-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.