From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966740AbdDZTbz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Apr 2017 15:31:55 -0400
Received: from mail-pf0-f180.google.com ([209.85.192.180]:34677 "EHLO
        mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966699AbdDZTbt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Apr 2017 15:31:49 -0400
Date: Wed, 26 Apr 2017 12:31:47 -0700
From: Matthias Kaehlcke <mka@chromium.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Grant Grundler <grundler@chromium.org>,
        Greg Hackmann <ghackmann@google.com>, Michael Davidson <md@google.com>
Subject: Re: [PATCH] x86/mm/kaslr: Add operand size suffix to 'mul'
 instruction
Message-ID: <20170426193147.GQ128305@google.com>
References: <20170426190112.98116-1-mka@chromium.org>
 <CAGXu5j+TH1-Jq=2Zh83KkJxdArJLtRctB=t_zVAk=f2pC-FSnA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAGXu5j+TH1-Jq=2Zh83KkJxdArJLtRctB=t_zVAk=f2pC-FSnA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kees,

El Wed, Apr 26, 2017 at 12:09:13PM -0700 Kees Cook ha dit:

> On Wed, Apr 26, 2017 at 12:01 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > In difference to gas clang doesn't seem to infer the size from the
> > operands. Adding the suffix fixes the following error when building
> > with clang:
> >
> > CC      arch/x86/lib/kaslr.o
> > /tmp/kaslr-dfe1ad.s: Assembler messages:
> > /tmp/kaslr-dfe1ad.s:182: Error: no instruction mnemonic suffix given and
> > no register operands; can't size instruction
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >  arch/x86/lib/kaslr.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c
> > index 121f59c6ee54..947d4aa92ff7 100644
> > --- a/arch/x86/lib/kaslr.c
> > +++ b/arch/x86/lib/kaslr.c
> > @@ -79,7 +79,11 @@ unsigned long kaslr_get_random_long(const char *purpose)
> >         }
> >
> >         /* Circular multiply for better bit diffusion */
> > -       asm("mul %3"
> > +#ifdef CONFIG_X86_64
> > +       asm("mulq %3"
> > +#else
> > +       asm("mull %3"
> > +#endif
> >             : "=a" (random), "=d" (raw)
> >             : "a" (random), "rm" (mix_const));
> >         random += raw;
> >
> 
> Since there may be more of these and we try to avoid #ifdef in .c
> files, I think we should create an isns helper macro and use it here
> instead. Like:
> 
> #ifdef CONFIG_X86_64
> # define ASM_MUL "mulq"
> #else
> # define ASM_MUL "mull"
> #endif
> 
> ...
> 
> 
> asm(ASM_MUL " %3" ...

Sounds very reasonable. Thanks for the suggestion, I'll rework the patch.

Matthias