From: Luck, Tony <tony.luck@intel.com>
To: lkp@lists.01.org
Subject: Re: [lkp-robot] [EDAC] e3c4ff6d8c: kmsg.EDAC_sbridge:Failed_to_register_device_with_error
Date: Wed, 26 Apr 2017 15:52:54 -0700 [thread overview]
Message-ID: <20170426225254.GA10131@intel.com> (raw)
In-Reply-To: <20170426222009.gsl4tjmuvm4ljk6t@pd.tnic>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
On Thu, Apr 27, 2017 at 12:20:09AM +0200, Borislav Petkov wrote:
> On Wed, Apr 26, 2017 at 02:06:02PM -0700, Luck, Tony wrote:
> > Then we'd try to load some other driver: sb_edac, skx_edac, etc. If
> > they get through the platform tests to find they are on the right
> > cpu model, and they find all the right PCIe devices to access memory
> > controller registers ... then they call edac_mc_add_mc() to tell
> > EDAC core they want to run things ... and that supplants ghes_edac.
>
> Yeah, but that means a serious EDAC core surgery as we've never
> supported more than one EDAC driver. What would be easier, IMO,
> is to move the reporting functionality from ghes_edac.c to
> drivers/acpi/apei/ghes.c and export only the EDAC tracepoint so that
> GHES can call into it. Through a notifier or so.
Ah, that sounds simpler.
> This way we'll get rid of the ghes_edac.c thing completely the
> functionality will be completely part of ghes.c in drivers/acpi/ and
> then we can load our platform drivers just the same.
>
> But that's definitely future work.
>
> I'd still like to apply the oneliner for 4.12 so that the bug Xiaolong
> reported doesn't happen. Ok?
Sure. That makes sense.
-Tony
next prev parent reply other threads:[~2017-04-26 22:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 2:20 [lkp-robot] [EDAC] e3c4ff6d8c: kmsg.EDAC_sbridge:Failed_to_register_device_with_error kernel test robot
2017-04-25 8:19 ` Borislav Petkov
2017-04-26 1:51 ` Ye Xiaolong
2017-04-26 5:50 ` Ye Xiaolong
2017-04-26 7:20 ` Borislav Petkov
2017-04-26 10:08 ` Borislav Petkov
2017-04-26 10:27 ` [PATCH] EDAC, ghes: Do not enable it by default Borislav Petkov
2017-04-26 21:06 ` [lkp-robot] [EDAC] e3c4ff6d8c: kmsg.EDAC_sbridge:Failed_to_register_device_with_error Luck, Tony
2017-04-26 22:20 ` Borislav Petkov
2017-04-26 22:52 ` Luck, Tony [this message]
2017-04-27 9:01 ` Borislav Petkov
2017-05-07 17:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426225254.GA10131@intel.com \
--to=tony.luck@intel.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.