All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
	Bin Liu <b-liu@ti.com>, Sasha Levin <sasha.levin@oracle.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH, 3.18-stable regression] gadgetfs: fix uninitialized variable in error handling
Date: Thu, 27 Apr 2017 11:57:16 +0200	[thread overview]
Message-ID: <20170427095716.GC1755@kroah.com> (raw)
In-Reply-To: <20170421130623.2668561-1-arnd@arndb.de>

On Fri, Apr 21, 2017 at 03:06:12PM +0200, Arnd Bergmann wrote:
> gcc warns about a bug in 3.18.y:
> 
> drivers/usb/gadget/legacy/inode.c:648:10: warning: 'value' may be used
> 
> This is caused by the backport of f01d35a15fa0416 from 4.0 to 3.18:
> c81fc59be42c6e0 gadgetfs: use-after-free in ->aio_read()
> 
> The backported patch was buggy, but the mainline code was rewritten
> in a larger patch directly following this one in a way that fixed the
> bug.
> 
> For stable, we should need only a one-line change to make sure we
> return an proper error code. It is very unlikely that anybody ever
> ran into the out-of-memory case here in practice, but the compiler
> is right in theory.
> 
> Fixes: c81fc59be42c ("gadgetfs: use-after-free in ->aio_read()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/usb/gadget/legacy/inode.c | 1 +
>  1 file changed, 1 insertion(+)

Now queued up, thanks!

greg k-h

  reply	other threads:[~2017-04-27  9:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 13:06 [PATCH, 3.18-stable regression] gadgetfs: fix uninitialized variable in error handling Arnd Bergmann
2017-04-27  9:57 ` Greg KH [this message]
2017-04-27 10:04 ` Patch "gadgetfs: fix uninitialized variable in error handling" has been added to the 3.18-stable tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170427095716.GC1755@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=b-liu@ti.com \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.