From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: completely ignore unknown open flags
Date: Thu, 27 Apr 2017 22:10:05 +0100 [thread overview]
Message-ID: <20170427211005.GF29622@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFxRFnayxF+sfPfofhf0PKzQ4DYf8Tc38x7ne_ocFUqnWw@mail.gmail.com>
On Thu, Apr 27, 2017 at 12:41:39PM -0700, Linus Torvalds wrote:
> On Thu, Apr 27, 2017 at 12:42 AM, Christoph Hellwig <hch@lst.de> wrote:
> > This is the fallout from the reject unknown flags discussion a few
> > weeks back. So to keep backwards compatibily we can't _reject_ unknown
> > flags. But we'd better totally ignore them and don't pass them to
> > file systems or back to userspace using fcntl.
>
> Ack, this makes sense to me. It's crazy to let fcntl etc show bits
> that the kernel isn't even using.
>
> I'm assuming this will come through Al eventually. It doesn't seem
> high-priority for me to worry about it just before the 4.11 release,
> but it might be worth marking for stable just to percolate the change
> eventually to other kernels, and keep these kinds of differences
> minimal.
Applied tonight, still hadn't pushed it out into -next - the tree goes through
testing.
next prev parent reply other threads:[~2017-04-27 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 7:42 completely ignore unknown open flags Christoph Hellwig
2017-04-27 7:42 ` [PATCH 1/2] fs: add a VALID_OPEN_FLAGS Christoph Hellwig
2017-04-27 7:42 ` [PATCH 2/2] fs: completely ignore unknown open flags Christoph Hellwig
2017-04-27 19:41 ` Linus Torvalds
2017-04-27 21:10 ` Al Viro [this message]
2017-04-28 15:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427211005.GF29622@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.