All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: hanxueluo@126.com
Cc: dev@dpdk.org, Huanle Han <hanxueluo@gmail.com>
Subject: Re: [PATCH 2/3] net/virtio: fix crash when close virtio dev twice
Date: Fri, 28 Apr 2017 12:56:22 +0800	[thread overview]
Message-ID: <20170428045622.GR11512@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20170222022413.GM18844@yliu-dev.sh.intel.com>

On Wed, Feb 22, 2017 at 10:24:13AM +0800, Yuanhan Liu wrote:
> On Mon, Feb 20, 2017 at 10:04:46PM +0800, hanxueluo@126.com wrote:
> > From: Huanle Han <hanxueluo@gmail.com>
> > 
> > This commit fixs segment fault when rte_eth_dev_close()
> > is called on a virtio dev more than once.
> > Assigning zero after free to avoids freed memory to
> > be accessed again.
> 
> Thanks for the fix! And here are few more minor nits you might want be
> awre of:
> 
> - a fix patch needs a fixline (check http://dpdk.org/dev for howto just
>   in case you don't know)
> 
> - if it fixes a fatal bug (like this one), it should also be picked (or
>   backported) to a specific stable release. In this case, you should add
>      Cc: stable@dpdk.org
> 
>   just before your SoB (Signed-off-by).

Applied to dpdk-next-virtio with:

    Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage")

    Cc: stable@dpdk.org

Thanks.

	--yliu

  reply	other threads:[~2017-04-28  4:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20 14:04 [PATCH 1/3] net/virtio: fix dev detachable flag hanxueluo
2017-02-20 14:04 ` [PATCH 2/3] net/virtio: fix crash when close virtio dev twice hanxueluo
2017-02-22  2:24   ` Yuanhan Liu
2017-04-28  4:56     ` Yuanhan Liu [this message]
2017-02-20 14:04 ` [PATCH 3/3] pci: fix crash caused by invaild memory write hanxueluo
2017-02-22  2:36   ` Yuanhan Liu
2017-05-01 22:59     ` Thomas Monjalon
2017-02-22  2:34 ` [PATCH 1/3] net/virtio: fix dev detachable flag Yuanhan Liu
2017-04-28  4:58   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428045622.GR11512@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=hanxueluo@126.com \
    --cc=hanxueluo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.