From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42045 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163938AbdD1Hpz (ORCPT ); Fri, 28 Apr 2017 03:45:55 -0400 Date: Fri, 28 Apr 2017 09:45:46 +0200 From: Greg KH To: Jon Maloy Cc: stable@vger.kernel.org, parthasarathy.bhuvaragan@ericsson.com, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net Subject: Re: [PATCH stable 4.4] tipc: move premature initialization of stack variables Message-ID: <20170428074546.GC30203@kroah.com> References: <1493324572-17567-1-git-send-email-jon.maloy@ericsson.com> <20170428074512.GB30203@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170428074512.GB30203@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Apr 28, 2017 at 09:45:12AM +0200, Greg KH wrote: > On Thu, Apr 27, 2017 at 10:22:52PM +0200, Jon Maloy wrote: > > From: Jon Paul Maloy > > > > commit 681a55d71799b575f46fe94121728cf67460d1c3 upstream > > > > (Slightly modified to apply cleanly) > > Belongs below the --- line. > > > > > In the function tipc_rcv() we initialize a couple of stack variables > > from the message header before that same header has been validated. > > In rare cases when the arriving header is non-linear, the validation > > function itself may linearize the buffer by calling skb_may_pull(), > > while the wrongly initialized stack fields are not updated accordingly. > > > > We fix this in this commit. > > > > Reported-by: Matthew Wong > > Signed-off-by: Jon Maloy > > Signed-off-by: David S. Miller > > > > Conflicts: > > net/tipc/node.c > > What are these lines for? Please don't do that, "Conflicts:" lines do > not belong in the changelog as they don't make any sense, right? Oh, and please fix this up and resend, I didn't take this patch. greg k-h