Re: [Qemu-devel] [PATCH 0/6] Move snapshots commands to hmp

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Juan Quintela (quintela@redhat.com) wrote:
> Hi
> 
> This series:
> - Move snapshots commands to hmp.c, as they don't have code for migration
> - Make them work with errors in a modern way instead of writting to the monitor
> - make paolo happy and use hmp_handle_error
> 
> Later, Juan.

I'm happy with 1-5, 6 though, see comments.

If you want I can merge 1-5 via my next HMP pull, otherwise
if you want to do them via migration I agree with Laurent's Rb's so

Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> 
> Juan Quintela (6):
>   monitor: Remove monitor parameter from save_vmstate
>   monitor: Move hmp_loadvm from monitor.c to hmp.c
>   monitor: Move hmp_savevm from savevm.c to hmp.c
>   monitor: Move hmp_delvm from savevm.c to hmp.c
>   monitor: Move hmp_info_snapshots from savevm.c to hmp.c
>   migration: Pass Error ** argument to {save,load}_vmstate
> 
>  hmp.c                    | 179 +++++++++++++++++++++++++++++++++++++++
>  hmp.h                    |   4 +
>  include/sysemu/sysemu.h  |   7 +-
>  migration/savevm.c       | 216 ++++++-----------------------------------------
>  monitor.c                |  13 ---
>  replay/replay-snapshot.c |   6 +-
>  vl.c                     |   4 +-
>  7 files changed, 217 insertions(+), 212 deletions(-)
> 
> -- 
> 2.9.3
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK