From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S642534AbdD1Tvo (ORCPT ); Fri, 28 Apr 2017 15:51:44 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:35645 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035424AbdD1Tvf (ORCPT ); Fri, 28 Apr 2017 15:51:35 -0400 Date: Fri, 28 Apr 2017 12:51:32 -0700 From: Brian Norris To: David Miller Cc: joe@perches.com, apw@canonical.com, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, mingo@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments Message-ID: <20170428195131.GA73503@google.com> References: <20170428175547.61114-1-briannorris@chromium.org> <1493403858.1873.5.camel@perches.com> <20170428192721.GA72697@google.com> <20170428.153133.431048256400360136.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170428.153133.431048256400360136.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2017 at 03:31:33PM -0400, David Miller wrote: > From: Brian Norris > Date: Fri, 28 Apr 2017 12:27:22 -0700 > > > On Fri, Apr 28, 2017 at 11:24:18AM -0700, Joe Perches wrote: > >> On Fri, 2017-04-28 at 10:55 -0700, Brian Norris wrote: > >> I believe the only person that actually cares about > >> the networking > >> comment style is David Miller. > > > > Which is why I've CC'd him. If even *he* doesn't care about having > > this warning in checkpatch, then why should anyone else? > > Well it potentially saves one round trip for patch submissions. > > What I'm not going to do is let people start using different comment > style even for new code in files like net/core/whatever.c after I've > spent nearly two decades getting them to be one way so far. Well, that sounds like mixed messages to me, but I suppose you're the (networking) boss. FWIW, I don't see this consistently applied at all. Unless my regexes are completely wrong [*], it's roughly 50/50 in drivers/net/ and net/, and roughly 40/60 (favoring "net" style) in net/core/. But if that's still the rule, then I guess I'll let this patch drop. And hope that I'm not the next one Linus notices using the net style and yells at. Brian [*] Which they quite likely are. But here goes: Multiline comment with '/*' on first line: \/\*$ Potential (doesn't catch all) multiline comment with '/*' followed by text: \/\*[^\*][^\*]*$ FWIW, kerneldoc gets counted for neither.