From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv5] mpir: fix build failure
Date: Mon, 1 May 2017 11:21:49 +0200 [thread overview]
Message-ID: <20170501112149.46c43ad1@free-electrons.com> (raw)
In-Reply-To: <1492774031-25802-1-git-send-email-semenak94@mail.ru>
Hello,
On Fri, 21 Apr 2017 14:27:11 +0300, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
When you're fixing build failures from the autobuilders, the commit log
should provide references to the autobuilder failures being fixed.
> +ifeq ($(BR2_MIPS_NABI64),y)
> +MPIR_CONF_OPTS += ABI=n64
> +endif
You did not even test this, because it fails to build:
configure: error: ABI=n64 is not among the following valid choices: 64 n32 o32
So I've fixed that to ABI=64
> +ifeq ($(BR2_powerpc_CLASSIC),y)
> +MPIR_CONF_OPTS += ABI=mode64
> +MPIR_CONF_ENV += MPN_PATH=generic
> +endif
This looks bogus. mode64 seems to refer to a 64-bit ABI, while
BR2_powerpc_CLASSIC is not necessarily 64 bit.
So, I've applied after changing ABI=n64 to ABI=64, dropping the PowerPC
stuff and adding a reference to the autobuilder failure being fixes.
That being said, there are still several other mpir related build
failures that have not been fixed:
* On ARM, we fail with the old Crosstool-NG toolchains, but apparently
not with other ARM toolchains. Both the ARMv5 and ARMv7 Crosstool-NG
toolchains are failing to build MPIR:
http://autobuild.buildroot.net/results/fd0/fd032f7dbd4cace84bb31e8017cb6139ef3c1072/build-end.log
http://autobuild.buildroot.net/results/c36/c360581c2925529f18635aac32c2865899f5e0f5/build-end.log
* On MIPS64r6
http://autobuild.buildroot.net/results/c45/c45dd59f10693b0d9a86dac4733c6c3dde4554f1/build-end.log
* On PowerPC64
http://autobuild.buildroot.net/results/be1/be1478836b2e7b580174641f48de92c9b02512a7/build-end.log
Could you have a look and fix those remaining issues?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-01 9:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mpir: fix build failure>
2017-04-17 13:59 ` [Buildroot] [PATCH] mpir: fix build failure Semyon Kolganov
2017-04-17 14:08 ` Yann E. MORIN
2017-04-17 14:20 ` Semen Kolganov
2017-04-17 14:40 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-17 14:57 ` Yann E. MORIN
2017-04-17 15:20 ` [Buildroot] [PATCHv3] mpir: fix build failure fixes: http://autobuild.buildroot.net/results/49b/49b4d4b8d8afc3e0353529146270ee8b289dc8be/ Semyon Kolganov
2017-04-18 19:59 ` Arnout Vandecappelle
2017-04-19 9:12 ` [Buildroot] [PATCHv4] mpir: fix build failure Semyon Kolganov
2017-04-21 11:27 ` [Buildroot] [PATCHv5] " Semyon Kolganov
2017-05-01 9:21 ` Thomas Petazzoni [this message]
2017-05-01 9:25 ` Thomas Petazzoni
2017-05-01 19:40 ` semenak94 at mail.ru
2017-04-19 9:37 Semen Kolganov
[not found] <mpir: new package>
2017-04-13 13:49 ` [Buildroot] [PATCH] mpir: new package Semyon Kolganov
2017-04-13 19:59 ` Thomas Petazzoni
[not found] ` <1492114114.644630127@f341.i.mail.ru>
2017-04-13 20:13 ` Thomas Petazzoni
2017-04-13 20:32 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-13 21:05 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501112149.46c43ad1@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.