From: Joe MacDonald <Joe_MacDonald@mentor.com>
To: <jackie.huang@windriver.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-selinux][PATCH] systemd: no need to inherit enable-selinux
Date: Tue, 2 May 2017 09:13:44 -0400 [thread overview]
Message-ID: <20170502131344.GD10652@mentor.com> (raw)
In-Reply-To: <20170222064446.13162-1-jackie.huang@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]
[[yocto] [meta-selinux][PATCH] systemd: no need to inherit enable-selinux] On 17.02.22 (Wed 14:44) jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> The selinux PACKAGECONFIG is properly handled in
> the recipe in oe-core, no need to inherit the
> enable-selinux bbclass.
That might be true, but other than belt-and-suspenders, what's the
harm in this being in the recipe? I don't necessarily think it's an
invalid change but my quick count shows ~44 instances of 'inherit
enable-selinux' and 'inherit with-selinux' in meta-selinux, why's this
one significant?
-J.
>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
> recipes-core/systemd/systemd_%.bbappend | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/recipes-core/systemd/systemd_%.bbappend b/recipes-core/systemd/systemd_%.bbappend
> index 8d9029b..f1bdaf8 100644
> --- a/recipes-core/systemd/systemd_%.bbappend
> +++ b/recipes-core/systemd/systemd_%.bbappend
> @@ -1,2 +1 @@
> inherit enable-audit
> -inherit enable-selinux
> --
> 2.8.3
>
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2017-05-02 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 6:44 [meta-selinux][PATCH] systemd: no need to inherit enable-selinux jackie.huang
2017-04-18 8:20 ` Huang, Jie (Jackie)
2017-05-02 13:13 ` Joe MacDonald [this message]
2017-05-08 1:40 ` Huang, Jie (Jackie)
2017-05-16 11:54 ` Joe MacDonald
2017-05-17 1:40 ` Huang, Jie (Jackie)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502131344.GD10652@mentor.com \
--to=joe_macdonald@mentor.com \
--cc=jackie.huang@windriver.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.