From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Vivek Goyal <vgoyal@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-unionfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: publish UUID in struct super_block
Date: Tue, 2 May 2017 16:17:51 +0200 [thread overview]
Message-ID: <20170502141751.GA21564@lst.de> (raw)
In-Reply-To: <CAOQ4uxjKbgCwhV4iBNVyfmS5+iR3o1BPF+PDj7YmrPP-qTv1eA@mail.gmail.com>
On Tue, May 02, 2017 at 05:13:56PM +0300, Amir Goldstein wrote:
> How can it create problems if uniqueness is not guaranteed with
> Current s_uuid? Even if we did make the xfs uuid table code generic
> It couldn't be the vfs default. Filesystems will have to opt in.
It creates problems if you e.g. mount an ext4 fs and a dm snaphot of
it. The non-XFS file systems are simply buggy in this regard.
Non-uniqueue uuids are an absolute no-go.
next prev parent reply other threads:[~2017-05-02 14:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 14:00 [PATCH v2] xfs: publish UUID in struct super_block Amir Goldstein
2017-04-28 15:13 ` Darrick J. Wong
2017-05-02 7:30 ` Christoph Hellwig
2017-05-02 14:13 ` Amir Goldstein
2017-05-02 14:17 ` Christoph Hellwig [this message]
2017-05-02 14:27 ` Amir Goldstein
2017-05-02 14:47 ` Christoph Hellwig
2017-05-02 15:08 ` Miklos Szeredi
2017-05-02 15:17 ` Christoph Hellwig
2017-05-02 17:09 ` Amir Goldstein
2017-05-02 18:25 ` Amir Goldstein
2017-05-02 18:30 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502141751.GA21564@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.