From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 2 May 2017 17:16:07 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , linux-block@vger.kernel.org, ming.lei@redhat.com Subject: Re: [PATCH 4/6] mtip32xx: convert internal command issue to block IO path Message-ID: <20170502151607.GA22963@lst.de> References: <1493398473-29872-1-git-send-email-axboe@fb.com> <1493398473-29872-5-git-send-email-axboe@fb.com> <20170502072810.GA11582@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: This looks reasonable to me, although of course I don't have a way to test it. Any reason for the move from ->end_io_data to ->special? I thought that ->special was something we'd get rid of sooner or later now that we can have additional per-cmd data even for !mq.