Re: [Qemu-devel] [PATCH v16 15/22] file-posix: Add 'locking' option

[Fam Zheng <famz@redhat.com>]

On Tue, 05/02 16:15, Kevin Wolf wrote:
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 1cf29a1..29d3040 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -2127,11 +2127,15 @@
> >  #
> >  # @filename:    path to the image file
> >  # @aio:         AIO backend (default: threads) (since: 2.8)
> > +# @locking:     whether to enable file locking. If set to 'auto', only enable
> > +#               when Open File Descriptor (OFD) locking API is available
> > +#               (default: auto, since 2.10)
> >  #
> >  # Since: 2.9
> >  ##
> >  { 'struct': 'BlockdevOptionsFile',
> >    'data': { 'filename': 'str',
> > +            '*locking': 'OnOffAuto',
> >              '*aio': 'BlockdevAioOptions' } }
> 
> It's unfortunate that file-posix and file-win32 share the same QAPI
> type. Should we add a file-win32 implementation that just errors out
> when locking=on is specified, or is it enough that block.c notices that
> there is an option that hasn't been processed? (Even locking=off would
> cause failure then.)

That will make it a bit more like an oversight, maybe only error out when
locking=on is better.

Fam