From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 4/4] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v2. Date: Wed, 3 May 2017 16:45:33 +0300 Message-ID: <20170503134533.GH12629@intel.com> References: <20170501133434.5683-1-maarten.lankhorst@linux.intel.com> <20170501133434.5683-5-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B5316E305 for ; Wed, 3 May 2017 13:45:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170501133434.5683-5-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXkgMDEsIDIwMTcgYXQgMDM6MzQ6MzRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlIHdhdGVybWFya3MgaXQgc2hvdWxkIGNhbGN1bGF0ZSBhZ2FpbnN0IGFy ZSB0aGUgb2xkIG9wdGltYWwgd2F0ZXJtYXJrcy4KPiBUaGUgY3VycmVudGx5IGFjdGl2ZSBjcnRj IHdhdGVybWFya3MgYXJlIHB1cmUgZmljdGlvbiwgYW5kIGFyZSBpbnZhbGlkIGluCj4gY2FzZSBv ZiBhIG5vbmJsb2NraW5nIG1vZGVzZXQsIHBhZ2UgZmxpcCBlbmFibGluZy9kaXNhYmxpbmcgcGxh bmVzIG9yIGFueQo+IG90aGVyIHJlYXNvbi4KPiAKPiBXaGVuIHRoZSBjcnRjIGlzIGRpc2FibGVk IG9yIGR1cmluZyBhIG1vZGVzZXQgdGhlIGludGVybWVkaWF0ZSB3YXRlcm1hcmtzCj4gZG9uJ3Qg bmVlZCB0byBiZSBwcm9ncmFtbWVkIHNlcGFyYXRlbHksIGFuZCBjb3VsZCBiZSBkaXJlY3RseSBh c3NpZ25lZAo+IHRvIHRoZSBvcHRpbWFsIHdhdGVybWFya3MuCj4gCj4gQWxzbyByZW5hbWUgY3J0 Y19zdGF0ZSB0byBuZXdfY3J0Y19zdGF0ZSwgdG8gZGlzdGluZ3Vpc2ggaXQgZnJvbSB0aGUgb2xk IHN0YXRlLgo+IAo+IENoYW5nZXMgc2luY2UgdjE6Cj4gLSBVc2UgaW50ZWxfYXRvbWljX2dldF9v bGRfY3J0Y19zdGF0ZS4gKHZpbGxlKQo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hv cnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyMCArKysrKysrKysrKysrKy0tLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiBpbmRleCAwZjM0NGIxZmZmNDUuLmEwOTM5NmVlMWYzZCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IEBAIC0xNDU4LDE2ICsxNDU4LDI0IEBAIHN0YXRpYyB2 b2lkIHZsdl9hdG9taWNfdXBkYXRlX2ZpZm8oc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3Rh dGUsCj4gIAo+ICBzdGF0aWMgaW50IHZsdl9jb21wdXRlX2ludGVybWVkaWF0ZV93bShzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LAo+ICAJCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ IC0JCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICsJCQkJ ICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiAgewo+IC0J c3RydWN0IHZsdl93bV9zdGF0ZSAqaW50ZXJtZWRpYXRlID0gJmNydGNfc3RhdGUtPndtLnZsdi5p bnRlcm1lZGlhdGU7Cj4gLQljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpvcHRpbWFsID0gJmNy dGNfc3RhdGUtPndtLnZsdi5vcHRpbWFsOwo+IC0JY29uc3Qgc3RydWN0IHZsdl93bV9zdGF0ZSAq YWN0aXZlID0gJmNydGMtPndtLmFjdGl2ZS52bHY7Cj4gKwlzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpp bnRlcm1lZGlhdGUgPSAmbmV3X2NydGNfc3RhdGUtPndtLnZsdi5pbnRlcm1lZGlhdGU7Cj4gKwlj b25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpvcHRpbWFsID0gJm5ld19jcnRjX3N0YXRlLT53bS52 bHYub3B0aW1hbDsKPiArCWNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19z dGF0ZSA9Cj4gKwkJaW50ZWxfYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0ZShuZXdfY3J0Y19zdGF0 ZS0+YmFzZS5zdGF0ZSwgY3J0Yyk7Cj4gKwljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICphY3Rp dmUgPSAmb2xkX2NydGNfc3RhdGUtPndtLnZsdi5vcHRpbWFsOwo+ICAJaW50IGxldmVsOwo+ICAK PiArCWlmICghbmV3X2NydGNfc3RhdGUtPmJhc2UuYWN0aXZlIHx8IGRybV9hdG9taWNfY3J0Y19u ZWVkc19tb2Rlc2V0KCZuZXdfY3J0Y19zdGF0ZS0+YmFzZSkpIHsKPiArCQkqaW50ZXJtZWRpYXRl ID0gKm9wdGltYWw7Cj4gKwo+ICsJCXJldHVybiAwOwo+ICsJfQo+ICsKPiAgCWludGVybWVkaWF0 ZS0+bnVtX2xldmVscyA9IG1pbihvcHRpbWFsLT5udW1fbGV2ZWxzLCBhY3RpdmUtPm51bV9sZXZl bHMpOwo+ICAJaW50ZXJtZWRpYXRlLT5jeHNyID0gb3B0aW1hbC0+Y3hzciAmJiBhY3RpdmUtPmN4 c3IgJiYKPiAtCQkhY3J0Y19zdGF0ZS0+ZGlzYWJsZV9jeHNyOwo+ICsJCSFuZXdfY3J0Y19zdGF0 ZS0+ZGlzYWJsZV9jeHNyOwoKV2UgbmVlZCB0byBjb25zaWRlciBkaXNhYmxlX2N4c3IgZXZlbiBp biB0aGUgbW9kZXNldCBjYXNlLgoKPiAgCj4gIAlmb3IgKGxldmVsID0gMDsgbGV2ZWwgPCBpbnRl cm1lZGlhdGUtPm51bV9sZXZlbHM7IGxldmVsKyspIHsKPiAgCQllbnVtIHBsYW5lX2lkIHBsYW5l X2lkOwo+IEBAIC0xNDkxLDcgKzE0OTksNyBAQCBzdGF0aWMgaW50IHZsdl9jb21wdXRlX2ludGVy bWVkaWF0ZV93bShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJICogb21pdCB0aGUgcG9zdC12 YmxhbmsgcHJvZ3JhbW1pbmc7IG9ubHkgdXBkYXRlIGlmIGl0J3MgZGlmZmVyZW50Lgo+ICAJICov Cj4gIAlpZiAobWVtY21wKGludGVybWVkaWF0ZSwgb3B0aW1hbCwgc2l6ZW9mKCppbnRlcm1lZGlh dGUpKSAhPSAwKQo+IC0JCWNydGNfc3RhdGUtPndtLm5lZWRfcG9zdHZibF91cGRhdGUgPSB0cnVl Owo+ICsJCW5ld19jcnRjX3N0YXRlLT53bS5uZWVkX3Bvc3R2YmxfdXBkYXRlID0gdHJ1ZTsKPiAg Cj4gIAlyZXR1cm4gMDsKPiAgfQo+IC0tIAo+IDIuOS4zCj4gCj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK