From: Jens Axboe <axboe@kernel.dk>
To: Vincent Fu <vincentfu@gmail.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH 1/6] stat: change json+ output format so that instead of printing the raw clat data structure, use actual durations instead of array indices and print only bins with nonzero counts
Date: Wed, 3 May 2017 08:50:13 -0600 [thread overview]
Message-ID: <20170503145012.GA22842@kernel.dk> (raw)
In-Reply-To: <23c62b4c-2aac-6a43-927f-69cfc036120a@gmail.com>
On Wed, May 03 2017, Vincent Fu wrote:
> Jens, can you review this patch series?
>
> The json+ change (PATCH 1/6 and 2/6) was a request from a user and makes the
> output easier to use.
>
> The other patches fix problems with resetting the latency counters when
> --latency-target is used (PATCH 4/6) and make sure some forgotten latency
> counters are transferred in client/server mode (PATCH 5/6). PATCH 6/6 is a
> cleanup. You can ignore PATCH 3/6.
Looks good to me, this got lost since it arrived while I was away on
vacation. I applied the series, skipping patch #3. Thanks Vincent!
--
Jens Axboe
prev parent reply other threads:[~2017-05-03 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 19:04 [PATCH 1/6] stat: change json+ output format so that instead of printing the raw clat data structure, use actual durations instead of array indices and print only bins with nonzero counts Vincent Fu
2017-04-16 19:04 ` [PATCH 2/6] Revert "tools/fio_latency2csv.py: add tool that converts json+ to CSV" Vincent Fu
2017-04-16 19:04 ` [PATCH 3/6] server: update server version for the addition of the --stats option Vincent Fu
2017-04-16 19:04 ` [PATCH 4/6] stat: reset_io_stats: fix a problem, rearrange some code Vincent Fu
2017-04-16 19:04 ` [PATCH 5/6] client/server: make sure that all elements in io_u_lat_m[] are transferred and received Vincent Fu
2017-04-16 19:04 ` [PATCH 6/6] gettime: make utime_since_now and mtime_since_now consistent in how they record the caller and put this all behind FIO_DEBUG_TIME Vincent Fu
2017-05-03 14:47 ` [PATCH 1/6] stat: change json+ output format so that instead of printing the raw clat data structure, use actual durations instead of array indices and print only bins with nonzero counts Vincent Fu
2017-05-03 14:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503145012.GA22842@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.