All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manasi Navare <manasi.d.navare@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH RESEND v4 5/6] drm: Add definition for eDP backlight frequency
Date: Wed, 3 May 2017 09:28:37 -0700	[thread overview]
Message-ID: <20170503162836.GA3834@intel.com> (raw)
In-Reply-To: <87shkmp0ks.fsf@intel.com>

On Wed, May 03, 2017 at 03:49:23PM +0300, Jani Nikula wrote:
> On Tue, 02 May 2017, Manasi Navare <manasi.d.navare@intel.com> wrote:
> > On Tue, Apr 18, 2017 at 04:48:23PM -0700, Puthikorn Voravootivat wrote:
> >
> > Since this adds definitions in the DRM layer, you need to copy
> > the dri-devel@lists.freedesktop.org M-L.
> >
> >> This patch adds the following definition
> >> - Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap
> >>   register which only use bit 0:4
> >> - Base frequency (27 MHz) for backlight PWM frequency
> >>   generator.
> >> 
> >> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
> >> ---
> >>  include/drm/drm_dp_helper.h | 2 ++
> >>  1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> >> index c0bd0d7651a9..9aee65ebc54c 100644
> >> --- a/include/drm/drm_dp_helper.h
> >> +++ b/include/drm/drm_dp_helper.h
> >> @@ -572,10 +572,12 @@
> >>  #define DP_EDP_PWMGEN_BIT_COUNT             0x724
> >>  #define DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN     0x725
> >>  #define DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX     0x726
> >> +# define  DP_EDP_PWMGEN_BIT_COUNT_MASK      (31 << 0)
> 
> For bit masks like this hex is preferred. 0x1f is way more intuitive
> than a decimal number.
> 
> >>  
> >>  #define DP_EDP_BACKLIGHT_CONTROL_STATUS     0x727
> >>  
> >>  #define DP_EDP_BACKLIGHT_FREQ_SET           0x728
> >> +# define DP_EDP_BACKLIGHT_FREQ_BASE         27000000
> >
> > Could you use HEX value to define this? Thats the convention around.
> 
> However I think this is fine as decimal.
> 
> BR,
> Jani.
> 
>

Yea it is the direct representation of 27MHz so I guess decimal
is more intuitive.

Manasi

> >
> > Manasi
> >>  
> >>  #define DP_EDP_BACKLIGHT_FREQ_CAP_MIN_MSB   0x72a
> >>  #define DP_EDP_BACKLIGHT_FREQ_CAP_MIN_MID   0x72b
> >> -- 
> >> 2.12.2.816.g2cccc81164-goog
> >> 
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-05-03 16:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 23:48 [PATCH RESEND v4 0/6] Enhancement to intel_dp_aux_backlight driver Puthikorn Voravootivat
2017-04-18 23:48 ` [PATCH RESEND v4 1/6] drm/i915: Add DPCD preferred mode for backlight control Puthikorn Voravootivat
2017-05-03  0:54   ` Pandiyan, Dhinakaran
2017-05-03  1:19     ` Pandiyan, Dhinakaran
2017-05-03  9:11   ` Jani Nikula
2017-05-03 23:47     ` Puthikorn Voravootivat
2017-04-18 23:48 ` [PATCH RESEND v4 2/6] drm/i915: Correctly enable blacklight adjustment via DPCD Puthikorn Voravootivat
2017-05-03  0:56   ` Pandiyan, Dhinakaran
2017-05-03  1:17   ` Pandiyan, Dhinakaran
2017-05-03  2:00   ` Manasi Navare
2017-05-03  9:19   ` Jani Nikula
2017-04-18 23:48 ` [PATCH RESEND v4 3/6] drm/i915: Support dynamic backlight via DPCD register Puthikorn Voravootivat
2017-05-03  3:00   ` Pandiyan, Dhinakaran
2017-05-03 22:16     ` Puthikorn Voravootivat
2017-04-18 23:48 ` [PATCH RESEND v4 4/6] drm/i915: Store brightness level in aux backlight driver Puthikorn Voravootivat
2017-05-03 11:32   ` Jani Nikula
2017-04-18 23:48 ` [PATCH RESEND v4 5/6] drm: Add definition for eDP backlight frequency Puthikorn Voravootivat
2017-05-03  1:27   ` Manasi Navare
2017-05-03 12:49     ` Jani Nikula
2017-05-03 16:28       ` Manasi Navare [this message]
2017-04-18 23:48 ` [PATCH RESEND v4 6/6] drm/i915: Set PWM divider to match desired frequency in vbt Puthikorn Voravootivat
2017-05-03  2:15   ` Pandiyan, Dhinakaran
2017-05-03  3:12     ` Manasi Navare
2017-05-03 14:12   ` Jani Nikula
2017-05-03 23:14     ` Puthikorn Voravootivat
2017-04-19  0:08 ` ✗ Fi.CI.BAT: warning for Enhancement to intel_dp_aux_backlight driver (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503162836.GA3834@intel.com \
    --to=manasi.d.navare@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=puthik@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.