From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5xZ2-00007c-DH for qemu-devel@nongnu.org; Wed, 03 May 2017 12:55:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5xYx-0008WO-HD for qemu-devel@nongnu.org; Wed, 03 May 2017 12:55:44 -0400 Received: from smtp.citrix.com ([66.165.176.89]:63790) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5xYw-0008W8-UZ for qemu-devel@nongnu.org; Wed, 03 May 2017 12:55:39 -0400 Date: Wed, 3 May 2017 17:55:36 +0100 From: Anthony PERARD Message-ID: <20170503165536.GC1553@perard.uk.xensource.com> References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> <6738c7d96a1c476187f69616f25b28d1@AMSPEX02CL03.citrite.net> <20170503164838.GB1553@perard.uk.xensource.com> <20170503165207.k4z3xwusbi4vmmf5@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170503165207.k4z3xwusbi4vmmf5@citrix.com> Subject: Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu Cc: Stefano Stabellini , Paul Durrant , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" On Wed, May 03, 2017 at 05:52:07PM +0100, Wei Liu wrote: > On Wed, May 03, 2017 at 05:48:38PM +0100, Anthony PERARD wrote: > > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > > I think xencall should be part of the base xen_stable_libs anyway. > > > > > > Yes, you are right. However I noticed that -lxencall needs to come after > > > -lxendevicemodel. So, I'll have to move -lxendevicemodel before > > > $xen_stable_libs, see below. I'll merge this patch into "configure: > > > detect presence of libxendevicemodel", if that's OK. > > > > > > diff --git a/configure b/configure > > > index 99d6cbc..3133ef8 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -1992,7 +1992,7 @@ if test "$xen" != "no" ; then > > > else > > > > > > xen_libs="-lxenstore -lxenctrl -lxenguest" > > > - xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn" > > > + xen_stable_libs="-lxencall -lxenforeignmemory -lxengnttab -lxenevtchn" > > > > > > # First we test whether Xen headers and libraries are available. > > > # If no, we are done and there is no Xen support. > > > @@ -2027,9 +2027,9 @@ int main(void) { > > > return 0; > > > } > > > EOF > > > - compile_prog "" "$xen_libs $xen_stable_libs -lxendevicemodel" > > > + compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs" > > > then > > > - xen_stable_libs="$xen_stable_libs -lxendevicemodel" > > > + xen_stable_libs="-lxendevicemodel $xen_stable_libs" > > > xen_ctrl_version=40900 > > > xen=yes > > > elif > > > > Hey, now that this patch is merged, xen.git fail to build QEMU. (osstest > > qemu-mainline branch fail.) > > > > That's because -lxencall is not found because -L$path_to_libxencall is > > missing in xen.git. > > > > But I've notice something else, libxendevicemodel.so is not linked > > against libxencall, that might be the root of the issues on arm. > > (libxenctrl.so is linked against libxencall.) > > > > Thought? > > > > > > We probably need this patch in xen: > > > > diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile > > index 55626a5049..81fa5a4ac4 100644 > > --- a/tools/libs/devicemodel/Makefile > > +++ b/tools/libs/devicemodel/Makefile > > @@ -63,7 +63,7 @@ libxendevicemodel.so.$(MAJOR): libxendevicemodel.so.$(MAJOR).$(MINOR) > > $(SYMLINK_SHLIB) $< $@ > > > > libxendevicemodel.so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxendevicemodel.map > > - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(APPEND_LDFLAGS) > > + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(APPEND_LDFLAGS) > > > > Isn't the dependency already encoded in tools/Rules.mk? How? Which makefile variable would include -lxencall in the abrove line? Also ldd libxendevicemodel.so does not list libxencall.so. -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel Date: Wed, 3 May 2017 17:55:36 +0100 Message-ID: <20170503165536.GC1553@perard.uk.xensource.com> References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> <6738c7d96a1c476187f69616f25b28d1@AMSPEX02CL03.citrite.net> <20170503164838.GB1553@perard.uk.xensource.com> <20170503165207.k4z3xwusbi4vmmf5@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5xZ2-00024o-G6 for xen-devel@lists.xenproject.org; Wed, 03 May 2017 16:55:44 +0000 Content-Disposition: inline In-Reply-To: <20170503165207.k4z3xwusbi4vmmf5@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , "qemu-devel@nongnu.org" , Paul Durrant List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBNYXkgMDMsIDIwMTcgYXQgMDU6NTI6MDdQTSArMDEwMCwgV2VpIExpdSB3cm90ZToK PiBPbiBXZWQsIE1heSAwMywgMjAxNyBhdCAwNTo0ODozOFBNICswMTAwLCBBbnRob255IFBFUkFS RCB3cm90ZToKPiA+IE9uIFRodSwgQXByIDIwLCAyMDE3IGF0IDExOjA1OjMzQU0gLTA3MDAsIFN0 ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToKPiA+ID4gT24gVGh1LCAyMCBBcHIgMjAxNywgUGF1bCBE dXJyYW50IHdyb3RlOgo+ID4gPiA+IEkgdGhpbmsgeGVuY2FsbCBzaG91bGQgYmUgcGFydCBvZiB0 aGUgYmFzZSB4ZW5fc3RhYmxlX2xpYnMgYW55d2F5Lgo+ID4gPiAKPiA+ID4gWWVzLCB5b3UgYXJl IHJpZ2h0LiBIb3dldmVyIEkgbm90aWNlZCB0aGF0IC1seGVuY2FsbCBuZWVkcyB0byBjb21lIGFm dGVyCj4gPiA+IC1seGVuZGV2aWNlbW9kZWwuIFNvLCBJJ2xsIGhhdmUgdG8gbW92ZSAtbHhlbmRl dmljZW1vZGVsIGJlZm9yZQo+ID4gPiAkeGVuX3N0YWJsZV9saWJzLCBzZWUgYmVsb3cuIEknbGwg bWVyZ2UgdGhpcyBwYXRjaCBpbnRvICJjb25maWd1cmU6Cj4gPiA+IGRldGVjdCBwcmVzZW5jZSBv ZiBsaWJ4ZW5kZXZpY2Vtb2RlbCIsIGlmIHRoYXQncyBPSy4KPiA+ID4gCj4gPiA+IGRpZmYgLS1n aXQgYS9jb25maWd1cmUgYi9jb25maWd1cmUKPiA+ID4gaW5kZXggOTlkNmNiYy4uMzEzM2VmOCAx MDA3NTUKPiA+ID4gLS0tIGEvY29uZmlndXJlCj4gPiA+ICsrKyBiL2NvbmZpZ3VyZQo+ID4gPiBA QCAtMTk5Miw3ICsxOTkyLDcgQEAgaWYgdGVzdCAiJHhlbiIgIT0gIm5vIiA7IHRoZW4KPiA+ID4g ICAgZWxzZQo+ID4gPiAgCj4gPiA+ICAgICAgeGVuX2xpYnM9Ii1seGVuc3RvcmUgLWx4ZW5jdHJs IC1seGVuZ3Vlc3QiCj4gPiA+IC0gICAgeGVuX3N0YWJsZV9saWJzPSItbHhlbmZvcmVpZ25tZW1v cnkgLWx4ZW5nbnR0YWIgLWx4ZW5ldnRjaG4iCj4gPiA+ICsgICAgeGVuX3N0YWJsZV9saWJzPSIt bHhlbmNhbGwgLWx4ZW5mb3JlaWdubWVtb3J5IC1seGVuZ250dGFiIC1seGVuZXZ0Y2huIgo+ID4g PiAgCj4gPiA+ICAgICAgIyBGaXJzdCB3ZSB0ZXN0IHdoZXRoZXIgWGVuIGhlYWRlcnMgYW5kIGxp YnJhcmllcyBhcmUgYXZhaWxhYmxlLgo+ID4gPiAgICAgICMgSWYgbm8sIHdlIGFyZSBkb25lIGFu ZCB0aGVyZSBpcyBubyBYZW4gc3VwcG9ydC4KPiA+ID4gQEAgLTIwMjcsOSArMjAyNyw5IEBAIGlu dCBtYWluKHZvaWQpIHsKPiA+ID4gICAgcmV0dXJuIDA7Cj4gPiA+ICB9Cj4gPiA+ICBFT0YKPiA+ ID4gLSAgICAgICAgY29tcGlsZV9wcm9nICIiICIkeGVuX2xpYnMgJHhlbl9zdGFibGVfbGlicyAt bHhlbmRldmljZW1vZGVsIgo+ID4gPiArICAgICAgICBjb21waWxlX3Byb2cgIiIgIiR4ZW5fbGli cyAtbHhlbmRldmljZW1vZGVsICR4ZW5fc3RhYmxlX2xpYnMiCj4gPiA+ICAgICAgICB0aGVuCj4g PiA+IC0gICAgICB4ZW5fc3RhYmxlX2xpYnM9IiR4ZW5fc3RhYmxlX2xpYnMgLWx4ZW5kZXZpY2Vt b2RlbCIKPiA+ID4gKyAgICAgIHhlbl9zdGFibGVfbGlicz0iLWx4ZW5kZXZpY2Vtb2RlbCAkeGVu X3N0YWJsZV9saWJzIgo+ID4gPiAgICAgICAgeGVuX2N0cmxfdmVyc2lvbj00MDkwMAo+ID4gPiAg ICAgICAgeGVuPXllcwo+ID4gPiAgICAgIGVsaWYKPiA+IAo+ID4gSGV5LCBub3cgdGhhdCB0aGlz IHBhdGNoIGlzIG1lcmdlZCwgeGVuLmdpdCBmYWlsIHRvIGJ1aWxkIFFFTVUuIChvc3N0ZXN0Cj4g PiBxZW11LW1haW5saW5lIGJyYW5jaCBmYWlsLikKPiA+IAo+ID4gVGhhdCdzIGJlY2F1c2UgLWx4 ZW5jYWxsIGlzIG5vdCBmb3VuZCBiZWNhdXNlIC1MJHBhdGhfdG9fbGlieGVuY2FsbCBpcwo+ID4g bWlzc2luZyBpbiB4ZW4uZ2l0Lgo+ID4gCj4gPiBCdXQgSSd2ZSBub3RpY2Ugc29tZXRoaW5nIGVs c2UsIGxpYnhlbmRldmljZW1vZGVsLnNvIGlzIG5vdCBsaW5rZWQKPiA+IGFnYWluc3QgbGlieGVu Y2FsbCwgdGhhdCBtaWdodCBiZSB0aGUgcm9vdCBvZiB0aGUgaXNzdWVzIG9uIGFybS4KPiA+IChs aWJ4ZW5jdHJsLnNvIGlzIGxpbmtlZCBhZ2FpbnN0IGxpYnhlbmNhbGwuKQo+ID4gCj4gPiBUaG91 Z2h0Pwo+ID4gCj4gPiAKPiA+IFdlIHByb2JhYmx5IG5lZWQgdGhpcyBwYXRjaCBpbiB4ZW46Cj4g PiAKPiA+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2RldmljZW1vZGVsL01ha2VmaWxlIGIvdG9v bHMvbGlicy9kZXZpY2Vtb2RlbC9NYWtlZmlsZQo+ID4gaW5kZXggNTU2MjZhNTA0OS4uODFmYTVh NGFjNCAxMDA2NDQKPiA+IC0tLSBhL3Rvb2xzL2xpYnMvZGV2aWNlbW9kZWwvTWFrZWZpbGUKPiA+ ICsrKyBiL3Rvb2xzL2xpYnMvZGV2aWNlbW9kZWwvTWFrZWZpbGUKPiA+IEBAIC02Myw3ICs2Myw3 IEBAIGxpYnhlbmRldmljZW1vZGVsLnNvLiQoTUFKT1IpOiBsaWJ4ZW5kZXZpY2Vtb2RlbC5zby4k KE1BSk9SKS4kKE1JTk9SKQo+ID4gICAgICAgICAkKFNZTUxJTktfU0hMSUIpICQ8ICRACj4gPiAg Cj4gPiAgbGlieGVuZGV2aWNlbW9kZWwuc28uJChNQUpPUikuJChNSU5PUik6ICQoUElDX09CSlMp IGxpYnhlbmRldmljZW1vZGVsLm1hcAo+ID4gLSAgICAgICAkKENDKSAkKExERkxBR1MpICQoUFRI UkVBRF9MREZMQUdTKSAtV2wsJChTT05BTUVfTERGTEFHKSAtV2wsbGlieGVuZGV2aWNlbW9kZWwu c28uJChNQUpPUikgJChTSExJQl9MREZMQUdTKSAtbyAkQCAkKFBJQ19PQkpTKSAkKExETElCU19s aWJ4ZW50b29sbG9nKSAkKEFQUEVORF9MREZMQUdTKQo+ID4gKyAgICAgICAkKENDKSAkKExERkxB R1MpICQoUFRIUkVBRF9MREZMQUdTKSAtV2wsJChTT05BTUVfTERGTEFHKSAtV2wsbGlieGVuZGV2 aWNlbW9kZWwuc28uJChNQUpPUikgJChTSExJQl9MREZMQUdTKSAtbyAkQCAkKFBJQ19PQkpTKSAk KExETElCU19saWJ4ZW50b29sbG9nKSAkKExETElCU19saWJ4ZW5jYWxsKSAkKEFQUEVORF9MREZM QUdTKQo+ID4gIAo+IAo+IElzbid0IHRoZSBkZXBlbmRlbmN5IGFscmVhZHkgZW5jb2RlZCBpbiB0 b29scy9SdWxlcy5taz8KCkhvdz8gV2hpY2ggbWFrZWZpbGUgdmFyaWFibGUgd291bGQgaW5jbHVk ZSAtbHhlbmNhbGwgaW4gdGhlIGFicm92ZSBsaW5lPwoKQWxzbyBsZGQgbGlieGVuZGV2aWNlbW9k ZWwuc28gZG9lcyBub3QgbGlzdCBsaWJ4ZW5jYWxsLnNvLgoKLS0gCkFudGhvbnkgUEVSQVJECgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK