From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 4/4] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v2. Date: Wed, 3 May 2017 21:03:53 +0300 Message-ID: <20170503180353.GQ12629@intel.com> References: <20170501133434.5683-1-maarten.lankhorst@linux.intel.com> <20170501133434.5683-5-maarten.lankhorst@linux.intel.com> <20170503134533.GH12629@intel.com> <587a919a-52a9-ed40-9e18-e6da724be1b0@linux.intel.com> <20170503141159.GM12629@intel.com> <3ceb1e81-539d-3290-6089-237403918b26@linux.intel.com> <20170503160758.GP12629@intel.com> <18fc85f7-cd67-4f53-5cdd-d5fadc65fa2e@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 581D189736 for ; Wed, 3 May 2017 18:03:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <18fc85f7-cd67-4f53-5cdd-d5fadc65fa2e@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDMsIDIwMTcgYXQgMDY6MTg6NDZQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDMtMDUtMTcgb20gMTg6MDcgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBXZWQsIE1heSAwMywgMjAxNyBhdCAwNTo1MzozNFBNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBPcCAwMy0wNS0xNyBvbSAxNjoxMSBzY2hyZWVmIFZpbGxlIFN5 cmrDpGzDpDoKPiA+Pj4gT24gV2VkLCBNYXkgMDMsIDIwMTcgYXQgMDQ6MDY6MzdQTSArMDIwMCwg TWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+PiBPcCAwMy0wNS0xNyBvbSAxNTo0NSBzY2hy ZWVmIFZpbGxlIFN5cmrDpGzDpDoKPiA+Pj4+PiBPbiBNb24sIE1heSAwMSwgMjAxNyBhdCAwMzoz NDozNFBNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+Pj4gVGhlIHdhdGVy bWFya3MgaXQgc2hvdWxkIGNhbGN1bGF0ZSBhZ2FpbnN0IGFyZSB0aGUgb2xkIG9wdGltYWwgd2F0 ZXJtYXJrcy4KPiA+Pj4+Pj4gVGhlIGN1cnJlbnRseSBhY3RpdmUgY3J0YyB3YXRlcm1hcmtzIGFy ZSBwdXJlIGZpY3Rpb24sIGFuZCBhcmUgaW52YWxpZCBpbgo+ID4+Pj4+PiBjYXNlIG9mIGEgbm9u YmxvY2tpbmcgbW9kZXNldCwgcGFnZSBmbGlwIGVuYWJsaW5nL2Rpc2FibGluZyBwbGFuZXMgb3Ig YW55Cj4gPj4+Pj4+IG90aGVyIHJlYXNvbi4KPiA+Pj4+Pj4KPiA+Pj4+Pj4gV2hlbiB0aGUgY3J0 YyBpcyBkaXNhYmxlZCBvciBkdXJpbmcgYSBtb2Rlc2V0IHRoZSBpbnRlcm1lZGlhdGUgd2F0ZXJt YXJrcwo+ID4+Pj4+PiBkb24ndCBuZWVkIHRvIGJlIHByb2dyYW1tZWQgc2VwYXJhdGVseSwgYW5k IGNvdWxkIGJlIGRpcmVjdGx5IGFzc2lnbmVkCj4gPj4+Pj4+IHRvIHRoZSBvcHRpbWFsIHdhdGVy bWFya3MuCj4gPj4+Pj4+Cj4gPj4+Pj4+IEFsc28gcmVuYW1lIGNydGNfc3RhdGUgdG8gbmV3X2Ny dGNfc3RhdGUsIHRvIGRpc3Rpbmd1aXNoIGl0IGZyb20gdGhlIG9sZCBzdGF0ZS4KPiA+Pj4+Pj4K PiA+Pj4+Pj4gQ2hhbmdlcyBzaW5jZSB2MToKPiA+Pj4+Pj4gLSBVc2UgaW50ZWxfYXRvbWljX2dl dF9vbGRfY3J0Y19zdGF0ZS4gKHZpbGxlKQo+ID4+Pj4+Pgo+ID4+Pj4+PiBTaWduZWQtb2ZmLWJ5 OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ ID4+Pj4+PiAtLS0KPiA+Pj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAy MCArKysrKysrKysrKysrKy0tLS0tLQo+ID4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2Vy dGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gPj4+Pj4+Cj4gPj4+Pj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcG0uYwo+ID4+Pj4+PiBpbmRleCAwZjM0NGIxZmZmNDUuLmEwOTM5NmVlMWYzZCAxMDA2NDQK PiA+Pj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4+Pj4+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPj4+Pj4+IEBAIC0xNDU4LDE2 ICsxNDU4LDI0IEBAIHN0YXRpYyB2b2lkIHZsdl9hdG9taWNfdXBkYXRlX2ZpZm8oc3RydWN0IGlu dGVsX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gPj4+Pj4+ICAKPiA+Pj4+Pj4gIHN0YXRpYyBpbnQg dmx2X2NvbXB1dGVfaW50ZXJtZWRpYXRlX3dtKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPj4+ Pj4+ICAJCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4+Pj4+PiAtCQkJCSAg ICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+Pj4+Pj4gKwkJCQkg ICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlKQo+ID4+Pj4+PiAg ewo+ID4+Pj4+PiAtCXN0cnVjdCB2bHZfd21fc3RhdGUgKmludGVybWVkaWF0ZSA9ICZjcnRjX3N0 YXRlLT53bS52bHYuaW50ZXJtZWRpYXRlOwo+ID4+Pj4+PiAtCWNvbnN0IHN0cnVjdCB2bHZfd21f c3RhdGUgKm9wdGltYWwgPSAmY3J0Y19zdGF0ZS0+d20udmx2Lm9wdGltYWw7Cj4gPj4+Pj4+IC0J Y29uc3Qgc3RydWN0IHZsdl93bV9zdGF0ZSAqYWN0aXZlID0gJmNydGMtPndtLmFjdGl2ZS52bHY7 Cj4gPj4+Pj4+ICsJc3RydWN0IHZsdl93bV9zdGF0ZSAqaW50ZXJtZWRpYXRlID0gJm5ld19jcnRj X3N0YXRlLT53bS52bHYuaW50ZXJtZWRpYXRlOwo+ID4+Pj4+PiArCWNvbnN0IHN0cnVjdCB2bHZf d21fc3RhdGUgKm9wdGltYWwgPSAmbmV3X2NydGNfc3RhdGUtPndtLnZsdi5vcHRpbWFsOwo+ID4+ Pj4+PiArCWNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSA9Cj4g Pj4+Pj4+ICsJCWludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUobmV3X2NydGNfc3RhdGUt PmJhc2Uuc3RhdGUsIGNydGMpOwo+ID4+Pj4+PiArCWNvbnN0IHN0cnVjdCB2bHZfd21fc3RhdGUg KmFjdGl2ZSA9ICZvbGRfY3J0Y19zdGF0ZS0+d20udmx2Lm9wdGltYWw7Cj4gPj4+Pj4+ICAJaW50 IGxldmVsOwo+ID4+Pj4+PiAgCj4gPj4+Pj4+ICsJaWYgKCFuZXdfY3J0Y19zdGF0ZS0+YmFzZS5h Y3RpdmUgfHwgZHJtX2F0b21pY19jcnRjX25lZWRzX21vZGVzZXQoJm5ld19jcnRjX3N0YXRlLT5i YXNlKSkgewo+ID4+Pj4+PiArCQkqaW50ZXJtZWRpYXRlID0gKm9wdGltYWw7Cj4gPj4+Pj4+ICsK PiA+Pj4+Pj4gKwkJcmV0dXJuIDA7Cj4gPj4+Pj4+ICsJfQo+ID4+Pj4+PiArCj4gPj4+Pj4+ICAJ aW50ZXJtZWRpYXRlLT5udW1fbGV2ZWxzID0gbWluKG9wdGltYWwtPm51bV9sZXZlbHMsIGFjdGl2 ZS0+bnVtX2xldmVscyk7Cj4gPj4+Pj4+ICAJaW50ZXJtZWRpYXRlLT5jeHNyID0gb3B0aW1hbC0+ Y3hzciAmJiBhY3RpdmUtPmN4c3IgJiYKPiA+Pj4+Pj4gLQkJIWNydGNfc3RhdGUtPmRpc2FibGVf Y3hzcjsKPiA+Pj4+Pj4gKwkJIW5ld19jcnRjX3N0YXRlLT5kaXNhYmxlX2N4c3I7Cj4gPj4+Pj4g V2UgbmVlZCB0byBjb25zaWRlciBkaXNhYmxlX2N4c3IgZXZlbiBpbiB0aGUgbW9kZXNldCBjYXNl Lgo+ID4+Pj4gV2h5IGlzIHRoaXM/IGNydGNfc3RhdGUtPmRpc2FibGVfY3hzciBpcyBzZXQgaWYg YW55IHBsYW5lIGlzIHBhcnQgb2YgdGhlIGNydGMgZHVyaW5nIG1vZGVzZXQsIHNvIGl0J3MgZGlz YWJsZWQgZHVyaW5nIG1vZGVzZXQgYWxyZWFkeS4KPiA+Pj4gSXQncyBzZXQgaWYgYW55IHBsYW5l IGlzIGVuYWJsaW5nL2Rpc2FibGluZywgd2hpY2ggc2hvdWxkIGJlIHF1aXRlCj4gPj4+IHR5cGlj YWwgZHVyaW5nIGEgbW9kZXNldC4KPiA+PiBZZWFoIGJ1dCAuaW5pdGlhbF93YXRlcm1hcmtzIGlz IGNhbGxlZCBkdXJpbmcgY3J0Y19lbmFibGUsIHNvIGN4c3Igd2lsbCBnZXQgZW5hYmxlZCBhbnl3 YXkuCj4gPiBXaGljaCBpcyBub3Qgd2hhdCB3ZSB3YW50LiBDeFNSIG11c3Qgc3RheSBvZmYgdW50 aWwgdGhlIHBsYW5lcyBoYXZlIGJlZW4KPiA+IGVuYWJsZWQuCj4gPgo+IEluIHRoYXQgY2FzZSB3 aHkgaXMgaXQgZW5hYmxlZCBpbiAuaW5pdGlhbF93YXRlcm1hcmtzIGF0IGFsbD8gSXQgc2hvdWxk IGJlIGluIG9wdGltaXplX3dhdGVybWFya3MgdGhlbi4uCgpCZWNhdXNlIHdlIGNhbiBrZWVwIGl0 IGVuYWJsZWQgYWNyb3NzIHRoZSB1cGRhdGUgdW5sZXNzIHBsYW5lcyBhcmUKZ2V0dGluZyBlbmFi bGVkIG9yIGRpc2FibGVkLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==