From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [git pull] device mapper changes for 4.12 Date: Wed, 3 May 2017 14:23:47 -0400 Message-ID: <20170503182346.GA24878@redhat.com> References: <20170502185847.GA79886@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Linus Torvalds Cc: Somasundaram Krishnasamy , Adrian Salido , Heinz Mauelshagen , Eric Biggers , Andy Shevchenko , Dennis Yang , Milan Broz , Vinothkumar Raja , Gilad Ben-Yossef , "dm-devel@redhat.com" , Matthias Kaehlcke , Mikulas Patocka , Tim Murray , Ondrej Kozina , Bart Van Assche , Joe Thornber , Alasdair G Kergon List-Id: dm-devel.ids On Wed, May 03 2017 at 1:51pm -0400, Linus Torvalds wrote: > On Tue, May 2, 2017 at 11:58 AM, Mike Snitzer wrote: > > > > - Add a new DM integrity target that emulates a block device that has > > additional per-sector tags that can be used for storing integrity > > information. > > So this one comes with a nice documentation file and everything, but > let me just quote all the help that you give users when faced with the > CONFIG_DM_INTEGRITY choice: > > CONFIG_DM_INTEGRITY: > > This is the integrity target. > > That's it. Not really very helpful. > > The kernel configuration phase is already likely the most frustrating > part of building your own kernel, it's really worth trying to make it > a *bit* less frustrating than this. > > Even just a stupid little blurb that says > > "Emulates a block device that has additional per-sector tags that can > be used for storing integrity information. > > If you're not sure, you can probably just say 'n'" > > or something like that. People who use this likely know they use it, > and it should lower the stress level for others. Sure thing. Sorry for it being so terse. I'll get it fixed and send it your way end of this week or early next (waiting on a dm-cache fix from Joe Thornber that I'll send at the same time). Thanks, Mike