All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com,
	jasowang@redhat.com, quintela@redhat.com, dovgaluk@ispras.ru,
	kraxel@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v9 04/10] replay: fix processing async events
Date: Thu, 04 May 2017 11:41:59 +0300	[thread overview]
Message-ID: <20170504084159.7488.97487.stgit@PASHA-ISP> (raw)
In-Reply-To: <20170504084135.7488.24715.stgit@PASHA-ISP>

From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>

Asynchronous events saved at checkpoints may invoke
callbacks when processed. These callbacks may also generate/read
new events (e.g. clock reads). Therefore event processing flag must be
reset before callback invocation.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay-events.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/replay/replay-events.c b/replay/replay-events.c
index 94a6dcccfc..768b505f3d 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -295,13 +295,13 @@ void replay_read_events(int checkpoint)
         if (!event) {
             break;
         }
+        replay_finish_event();
+        read_event_kind = -1;
         replay_mutex_unlock();
         replay_run_event(event);
         replay_mutex_lock();
 
         g_free(event);
-        replay_finish_event();
-        read_event_kind = -1;
     }
 }
 

  parent reply	other threads:[~2017-05-04  8:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04  8:41 [Qemu-devel] [PATCH v9 00/10] replay additions Pavel Dovgalyuk
2017-05-04  8:41 ` [Qemu-devel] [PATCH v9 01/10] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-05-04  8:41 ` [Qemu-devel] [PATCH v9 02/10] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-05-04  8:41 ` [Qemu-devel] [PATCH v9 03/10] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2017-05-04  8:41 ` Pavel Dovgalyuk [this message]
2017-05-04 10:30   ` [Qemu-devel] [PATCH v9 04/10] replay: fix processing async events Paolo Bonzini
2017-05-04 12:32     ` Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 05/10] replay: fixed replay_enable_events Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2017-05-04  9:33   ` Juan Quintela
2017-05-04 10:03     ` Pavel Dovgalyuk
2017-05-04 10:31   ` Paolo Bonzini
2017-05-04 11:13     ` Pavel Dovgalyuk
2017-05-04 11:52       ` Paolo Bonzini
2017-05-04 11:54         ` Pavel Dovgalyuk
2017-05-04 12:02           ` Paolo Bonzini
2017-05-04 12:10             ` Pavel Dovgalyuk
2017-05-04 12:32               ` Paolo Bonzini
2017-05-04 12:34                 ` Pavel Dovgalyuk
2017-05-04 12:52                   ` Paolo Bonzini
2017-05-04 13:02                     ` Pavel Dovgalyuk
2017-05-04 13:12                       ` Paolo Bonzini
2017-05-04 13:24                         ` Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 07/10] replay: added replay log format description Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 08/10] replay: make safe vmstop at record/replay Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 09/10] replay: save prior value of the host clock Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 10/10] icount: fixed saving/restoring of icount warp timers Pavel Dovgalyuk
2017-05-04  9:35 ` [Qemu-devel] [PATCH v9 00/10] replay additions no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504084159.7488.97487.stgit@PASHA-ISP \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=dovgaluk@ispras.ru \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.