From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 4/4] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v2. Date: Thu, 4 May 2017 13:56:32 +0300 Message-ID: <20170504105632.GR12629@intel.com> References: <20170501133434.5683-1-maarten.lankhorst@linux.intel.com> <20170501133434.5683-5-maarten.lankhorst@linux.intel.com> <20170503134533.GH12629@intel.com> <587a919a-52a9-ed40-9e18-e6da724be1b0@linux.intel.com> <20170503141159.GM12629@intel.com> <3ceb1e81-539d-3290-6089-237403918b26@linux.intel.com> <20170503160758.GP12629@intel.com> <18fc85f7-cd67-4f53-5cdd-d5fadc65fa2e@linux.intel.com> <20170503180353.GQ12629@intel.com> <6733eab3-0b68-9783-d56d-e76cbd22dcb5@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EF5E6E031 for ; Thu, 4 May 2017 10:56:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <6733eab3-0b68-9783-d56d-e76cbd22dcb5@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXkgMDQsIDIwMTcgYXQgMTA6MTI6NTJBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDMtMDUtMTcgb20gMjA6MDMgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBXZWQsIE1heSAwMywgMjAxNyBhdCAwNjoxODo0NlBNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBPcCAwMy0wNS0xNyBvbSAxODowNyBzY2hyZWVmIFZpbGxlIFN5 cmrDpGzDpDoKPiA+Pj4gT24gV2VkLCBNYXkgMDMsIDIwMTcgYXQgMDU6NTM6MzRQTSArMDIwMCwg TWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+PiBPcCAwMy0wNS0xNyBvbSAxNjoxMSBzY2hy ZWVmIFZpbGxlIFN5cmrDpGzDpDoKPiA+Pj4+PiBPbiBXZWQsIE1heSAwMywgMjAxNyBhdCAwNDow NjozN1BNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+Pj4gT3AgMDMtMDUt MTcgb20gMTU6NDUgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gPj4+Pj4+PiBPbiBNb24sIE1h eSAwMSwgMjAxNyBhdCAwMzozNDozNFBNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToK PiA+Pj4+Pj4+PiBUaGUgd2F0ZXJtYXJrcyBpdCBzaG91bGQgY2FsY3VsYXRlIGFnYWluc3QgYXJl IHRoZSBvbGQgb3B0aW1hbCB3YXRlcm1hcmtzLgo+ID4+Pj4+Pj4+IFRoZSBjdXJyZW50bHkgYWN0 aXZlIGNydGMgd2F0ZXJtYXJrcyBhcmUgcHVyZSBmaWN0aW9uLCBhbmQgYXJlIGludmFsaWQgaW4K PiA+Pj4+Pj4+PiBjYXNlIG9mIGEgbm9uYmxvY2tpbmcgbW9kZXNldCwgcGFnZSBmbGlwIGVuYWJs aW5nL2Rpc2FibGluZyBwbGFuZXMgb3IgYW55Cj4gPj4+Pj4+Pj4gb3RoZXIgcmVhc29uLgo+ID4+ Pj4+Pj4+Cj4gPj4+Pj4+Pj4gV2hlbiB0aGUgY3J0YyBpcyBkaXNhYmxlZCBvciBkdXJpbmcgYSBt b2Rlc2V0IHRoZSBpbnRlcm1lZGlhdGUgd2F0ZXJtYXJrcwo+ID4+Pj4+Pj4+IGRvbid0IG5lZWQg dG8gYmUgcHJvZ3JhbW1lZCBzZXBhcmF0ZWx5LCBhbmQgY291bGQgYmUgZGlyZWN0bHkgYXNzaWdu ZWQKPiA+Pj4+Pj4+PiB0byB0aGUgb3B0aW1hbCB3YXRlcm1hcmtzLgo+ID4+Pj4+Pj4+Cj4gPj4+ Pj4+Pj4gQWxzbyByZW5hbWUgY3J0Y19zdGF0ZSB0byBuZXdfY3J0Y19zdGF0ZSwgdG8gZGlzdGlu Z3Vpc2ggaXQgZnJvbSB0aGUgb2xkIHN0YXRlLgo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4gQ2hhbmdl cyBzaW5jZSB2MToKPiA+Pj4+Pj4+PiAtIFVzZSBpbnRlbF9hdG9taWNfZ2V0X29sZF9jcnRjX3N0 YXRlLiAodmlsbGUpCj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVu IExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+ID4+Pj4+Pj4+ IC0tLQo+ID4+Pj4+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgMjAgKysr KysrKysrKysrKystLS0tLS0KPiA+Pj4+Pj4+PiAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlv bnMoKyksIDYgZGVsZXRpb25zKC0pCj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BtLmMKPiA+Pj4+Pj4+PiBpbmRleCAwZjM0NGIxZmZmNDUuLmEwOTM5NmVlMWYzZCAxMDA2 NDQKPiA+Pj4+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPj4+ Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4+Pj4+Pj4+IEBA IC0xNDU4LDE2ICsxNDU4LDI0IEBAIHN0YXRpYyB2b2lkIHZsdl9hdG9taWNfdXBkYXRlX2ZpZm8o c3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gPj4+Pj4+Pj4gIAo+ID4+Pj4+Pj4+ ICBzdGF0aWMgaW50IHZsdl9jb21wdXRlX2ludGVybWVkaWF0ZV93bShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ID4+Pj4+Pj4+ICAJCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ ID4+Pj4+Pj4+IC0JCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRl KQo+ID4+Pj4+Pj4+ICsJCQkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0 Y19zdGF0ZSkKPiA+Pj4+Pj4+PiAgewo+ID4+Pj4+Pj4+IC0Jc3RydWN0IHZsdl93bV9zdGF0ZSAq aW50ZXJtZWRpYXRlID0gJmNydGNfc3RhdGUtPndtLnZsdi5pbnRlcm1lZGlhdGU7Cj4gPj4+Pj4+ Pj4gLQljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpvcHRpbWFsID0gJmNydGNfc3RhdGUtPndt LnZsdi5vcHRpbWFsOwo+ID4+Pj4+Pj4+IC0JY29uc3Qgc3RydWN0IHZsdl93bV9zdGF0ZSAqYWN0 aXZlID0gJmNydGMtPndtLmFjdGl2ZS52bHY7Cj4gPj4+Pj4+Pj4gKwlzdHJ1Y3Qgdmx2X3dtX3N0 YXRlICppbnRlcm1lZGlhdGUgPSAmbmV3X2NydGNfc3RhdGUtPndtLnZsdi5pbnRlcm1lZGlhdGU7 Cj4gPj4+Pj4+Pj4gKwljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpvcHRpbWFsID0gJm5ld19j cnRjX3N0YXRlLT53bS52bHYub3B0aW1hbDsKPiA+Pj4+Pj4+PiArCWNvbnN0IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSA9Cj4gPj4+Pj4+Pj4gKwkJaW50ZWxfYXRvbWlj X2dldF9vbGRfY3J0Y19zdGF0ZShuZXdfY3J0Y19zdGF0ZS0+YmFzZS5zdGF0ZSwgY3J0Yyk7Cj4g Pj4+Pj4+Pj4gKwljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICphY3RpdmUgPSAmb2xkX2NydGNf c3RhdGUtPndtLnZsdi5vcHRpbWFsOwo+ID4+Pj4+Pj4+ICAJaW50IGxldmVsOwo+ID4+Pj4+Pj4+ ICAKPiA+Pj4+Pj4+PiArCWlmICghbmV3X2NydGNfc3RhdGUtPmJhc2UuYWN0aXZlIHx8IGRybV9h dG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KCZuZXdfY3J0Y19zdGF0ZS0+YmFzZSkpIHsKPiA+Pj4+ Pj4+PiArCQkqaW50ZXJtZWRpYXRlID0gKm9wdGltYWw7Cj4gPj4+Pj4+Pj4gKwo+ID4+Pj4+Pj4+ ICsJCXJldHVybiAwOwo+ID4+Pj4+Pj4+ICsJfQo+ID4+Pj4+Pj4+ICsKPiA+Pj4+Pj4+PiAgCWlu dGVybWVkaWF0ZS0+bnVtX2xldmVscyA9IG1pbihvcHRpbWFsLT5udW1fbGV2ZWxzLCBhY3RpdmUt Pm51bV9sZXZlbHMpOwo+ID4+Pj4+Pj4+ICAJaW50ZXJtZWRpYXRlLT5jeHNyID0gb3B0aW1hbC0+ Y3hzciAmJiBhY3RpdmUtPmN4c3IgJiYKPiA+Pj4+Pj4+PiAtCQkhY3J0Y19zdGF0ZS0+ZGlzYWJs ZV9jeHNyOwo+ID4+Pj4+Pj4+ICsJCSFuZXdfY3J0Y19zdGF0ZS0+ZGlzYWJsZV9jeHNyOwo+ID4+ Pj4+Pj4gV2UgbmVlZCB0byBjb25zaWRlciBkaXNhYmxlX2N4c3IgZXZlbiBpbiB0aGUgbW9kZXNl dCBjYXNlLgo+ID4+Pj4+PiBXaHkgaXMgdGhpcz8gY3J0Y19zdGF0ZS0+ZGlzYWJsZV9jeHNyIGlz IHNldCBpZiBhbnkgcGxhbmUgaXMgcGFydCBvZiB0aGUgY3J0YyBkdXJpbmcgbW9kZXNldCwgc28g aXQncyBkaXNhYmxlZCBkdXJpbmcgbW9kZXNldCBhbHJlYWR5Lgo+ID4+Pj4+IEl0J3Mgc2V0IGlm IGFueSBwbGFuZSBpcyBlbmFibGluZy9kaXNhYmxpbmcsIHdoaWNoIHNob3VsZCBiZSBxdWl0ZQo+ ID4+Pj4+IHR5cGljYWwgZHVyaW5nIGEgbW9kZXNldC4KPiA+Pj4+IFllYWggYnV0IC5pbml0aWFs X3dhdGVybWFya3MgaXMgY2FsbGVkIGR1cmluZyBjcnRjX2VuYWJsZSwgc28gY3hzciB3aWxsIGdl dCBlbmFibGVkIGFueXdheS4KPiA+Pj4gV2hpY2ggaXMgbm90IHdoYXQgd2Ugd2FudC4gQ3hTUiBt dXN0IHN0YXkgb2ZmIHVudGlsIHRoZSBwbGFuZXMgaGF2ZSBiZWVuCj4gPj4+IGVuYWJsZWQuCj4g Pj4+Cj4gPj4gSW4gdGhhdCBjYXNlIHdoeSBpcyBpdCBlbmFibGVkIGluIC5pbml0aWFsX3dhdGVy bWFya3MgYXQgYWxsPyBJdCBzaG91bGQgYmUgaW4gb3B0aW1pemVfd2F0ZXJtYXJrcyB0aGVuLi4K PiA+IEJlY2F1c2Ugd2UgY2FuIGtlZXAgaXQgZW5hYmxlZCBhY3Jvc3MgdGhlIHVwZGF0ZSB1bmxl c3MgcGxhbmVzIGFyZQo+ID4gZ2V0dGluZyBlbmFibGVkIG9yIGRpc2FibGVkLgo+ID4KPiBTbyBm b3IgdGhlIG1vZGVzZXQgY2FzZSwgY29tcHV0aW5nIGludGVybWVkaWF0ZSB3YXRlcm1hcmtzOgo+ IAo+ICppbnRlcm1lZGlhdGUgPSAqb3B0aW1hbDsKPiBpZiAobmVlZHNfbW9kZXNldCkKPiAJaW50 ZXJtZWRpYXRlLT5jeHNyID0gZmFsc2U7Cj4gCj4gaWYgKG9wdGltYWwtPmN4c3IgJiYgIWludGVy bWVkaWF0ZS0+Y3hzcikKPiAJbmV3X2NydGNfc3RhdGUtPndtLm5lZWRfcG9zdHZibF91cGRhdGUg PSB0cnVlOwo+IAo+ID8KCgpPciBtYXliZQoKCWlmIChibGFoKSB7CgkJKmludGVybWVkaWF0ZSA9 ICpvcHRpbWFsOwoJCWdvdG8gb3V0OwoJfQoKCS8vIG1pbi9tYXggc3R1ZmYKCm91dDoKCWlmIChk aXNhYmxlX2N4c3IpCgkJaW50ZXJtZWRpYXRlLT5jeHNyID0gZmFsc2U7CglpZiAobWVtY21wKC4u LgoKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=