All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] leds: Delete obsolete Versatile driver
Date: Thu, 4 May 2017 14:28:47 +0200	[thread overview]
Message-ID: <20170504122847.GC32103@amd> (raw)
In-Reply-To: <CACRpkdaHxKMb=FRKdfNixry3TNPJo_hjqbxBm-oq8NfrHbkuYA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

On Thu 2017-05-04 14:23:39, Linus Walleij wrote:
> On Thu, May 4, 2017 at 2:14 PM, Pavel Machek <pavel@ucw.cz> wrote:
> 
> > On Thu 2017-05-04 14:03:08, Linus Walleij wrote:
> >> All users of the Versatile LED driver are deleted and replaced
> >> with the very generic leds-syscon. Delete the old driver.
> >
> > If someone has LEDS_VERSATILE selected, he'll be unhappy if we apply
> > first.
> >
> > Are you sure no _users_ have LEDS_VERSATILE selected? Should we give
> > them some kind of warning? (#warning, printk, ...?)
> 
> Since the driver cannot probe from device tree or ACPI, the device must
> be created in a board file using the device name "versatile-leds" which is
> what the driver matches against.
> 
> For them to use it they must have out-of-tree boardfiles, and we discourage
> both out-of-tree code and boardfiles.
> 
> The last boardfiles using this were deleted in
> commit 7484c727b636a838818e71f6d03114633b25aba2
> "ARM: realview: delete the RealView board files".
> 
> All Versatile, Integrator and RealView boards (the only one using the
> versatile LEDs), have been migrated to use leds-syscon.c.

Aha, people having out-of-tree boardfiles probably know enough to
handle this.

Acked-by: Pavel Machek <pavel@ucw.cz>
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-05-04 12:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 12:03 [PATCH] leds: Delete obsolete Versatile driver Linus Walleij
2017-05-04 12:14 ` Pavel Machek
2017-05-04 12:23   ` Linus Walleij
2017-05-04 12:28     ` Pavel Machek [this message]
2017-05-04 19:26       ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504122847.GC32103@amd \
    --to=pavel@ucw.cz \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.