Re: [PATCH v2 05/15] IB/hfi1: Adjust default eager_buffer_size to 8MB

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]

On Thu, May 04, 2017 at 05:14:22AM -0700, Dennis Dalessandro wrote:
> From: Tymoteusz Kielan <tymoteusz.kielan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Performance analysis shows benefits for PSM2 in increasing eager buffer
> size from 2MB to 8MB. The change has neutral impact on verbs.
> Make change to the module parameter's default value. Allocation
> ring down was verified to work with the larger buffer size.
>
> Reviewed-by: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Tymoteusz Kielan <tymoteusz.kielan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---

Impressive list :)


>  drivers/infiniband/hw/hfi1/init.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
> index 71b0204..c573f06 100644
> --- a/drivers/infiniband/hw/hfi1/init.c
> +++ b/drivers/infiniband/hw/hfi1/init.c
> @@ -102,9 +102,9 @@
>  module_param_named(rcvarr_split, hfi1_rcvarr_split, uint, S_IRUGO);
>  MODULE_PARM_DESC(rcvarr_split, "Percent of context's RcvArray entries used for Eager buffers");
>
> -static uint eager_buffer_size = (2 << 20); /* 2MB */
> +static uint eager_buffer_size = (8 << 20); /* 8MB */
>  module_param(eager_buffer_size, uint, S_IRUGO);
> -MODULE_PARM_DESC(eager_buffer_size, "Size of the eager buffers, default: 2MB");
> +MODULE_PARM_DESC(eager_buffer_size, "Size of the eager buffers, default: 8MB");
>
>  static uint rcvhdrcnt = 2048; /* 2x the max eager buffer count */
>  module_param_named(rcvhdrcnt, rcvhdrcnt, uint, S_IRUGO);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]