From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>,
target-devel@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Christoph Hellwig <hch@lst.de>, Andy Grover <agrover@redhat.com>,
David Disseldorp <ddiss@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH 03/19] target: Avoid that aborting a command sporadically hangs
Date: Fri, 5 May 2017 10:53:55 +0200 [thread overview]
Message-ID: <20170505085355.GC4858@lst.de> (raw)
In-Reply-To: <20170504225102.8931-4-bart.vanassche@sandisk.com>
On Thu, May 04, 2017 at 03:50:46PM -0700, Bart Van Assche wrote:
> For several target drivers (e.g. ib_srpt and ib_isert) sleeping inside
> transport_generic_free_cmd() causes RDMA completion processing to stall.
> Hence only sleep inside this function if the (iSCSI) target driver
> requires this.
This looks reasonable to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But as a further step can we try to move the waiting behavior entirely
into the caller that actually cares,
e.g. move the conditional target_wait_free_cmd before the call
to transport_generic_free_cmd in transport_generic_free_cmd,
and move this second wait_for_completion after the
transport_generic_free_cmd call based on an indicator (return value
or se_cmd flag)?
next prev parent reply other threads:[~2017-05-05 8:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170504225102.8931-1-bart.vanassche@sandisk.com>
2017-05-04 22:50 ` [PATCH 03/19] target: Avoid that aborting a command sporadically hangs Bart Van Assche
2017-05-05 6:12 ` Hannes Reinecke
2017-05-05 8:53 ` Christoph Hellwig [this message]
2017-05-05 15:00 ` Bart Van Assche
2017-05-11 0:23 ` Bart Van Assche
2017-05-07 22:20 ` Nicholas A. Bellinger
2017-05-08 21:25 ` Bart Van Assche
2017-05-10 4:48 ` Nicholas A. Bellinger
2017-05-04 22:50 ` [PATCH 04/19] target/fileio: Avoid that zero-length READ and WRITE commands hang Bart Van Assche
2017-05-05 6:14 ` Hannes Reinecke
2017-05-05 8:54 ` Christoph Hellwig
2017-05-07 22:28 ` Nicholas A. Bellinger
2017-05-04 22:50 ` [PATCH 05/19] target: Allocate sg-list correctly Bart Van Assche
2017-05-05 6:15 ` Hannes Reinecke
2017-05-05 9:06 ` Christoph Hellwig
2017-05-05 15:49 ` Bart Van Assche
2017-05-07 22:45 ` Nicholas A. Bellinger
2017-05-08 17:46 ` Bart Van Assche
2017-05-10 4:03 ` Nicholas A. Bellinger
2017-05-10 6:12 ` Nicholas A. Bellinger
2017-05-10 20:31 ` Bart Van Assche
2017-05-11 5:28 ` Nicholas A. Bellinger
2017-05-04 22:50 ` [PATCH 06/19] target: Fix data buffer size for VERIFY and WRITE AND VERIFY commands Bart Van Assche
2017-05-05 9:42 ` Christoph Hellwig
2017-05-05 15:51 ` Bart Van Assche
2017-05-07 22:49 ` Nicholas A. Bellinger
2017-05-08 18:07 ` Bart Van Assche
2017-05-10 4:28 ` Nicholas A. Bellinger
2017-05-10 15:16 ` Bart Van Assche
2017-05-11 5:09 ` Nicholas A. Bellinger
2017-05-04 22:51 ` [PATCH 17/19] target/iscsi: Simplify timer manipulation code Bart Van Assche
2017-05-05 11:24 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505085355.GC4858@lst.de \
--to=hch@lst.de \
--cc=agrover@redhat.com \
--cc=bart.vanassche@sandisk.com \
--cc=ddiss@suse.de \
--cc=hare@suse.com \
--cc=nab@linux-iscsi.org \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.