From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 1/6] drm: Add writeback connector type Date: Fri, 5 May 2017 10:22:19 +0200 Message-ID: <20170505102219.0ed543d2@bbrezillon> References: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> <1480092544-1725-2-git-send-email-brian.starkey@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 576866E619 for ; Fri, 5 May 2017 08:22:22 +0000 (UTC) In-Reply-To: <1480092544-1725-2-git-send-email-brian.starkey@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Starkey Cc: linux-media@vger.kernel.org, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNSBOb3YgMjAxNiAxNjo0ODo1OSArMDAwMApCcmlhbiBTdGFya2V5IDxicmlhbi5z dGFya2V5QGFybS5jb20+IHdyb3RlOgoKPiArLyoqCj4gKyAqIGRybV93cml0ZWJhY2tfY29ubmVj dG9yX2luaXQgLSBJbml0aWFsaXplIGEgd3JpdGViYWNrIGNvbm5lY3RvciBhbmQgaXRzIHByb3Bl cnRpZXMKPiArICogQGRldjogRFJNIGRldmljZQo+ICsgKiBAd2JfY29ubmVjdG9yOiBXcml0ZWJh Y2sgY29ubmVjdG9yIHRvIGluaXRpYWxpemUKPiArICogQGZ1bmNzOiBDb25uZWN0b3IgZnVuY3Mg dnRhYmxlCj4gKyAqIEBmb3JtYXRzOiBBcnJheSBvZiBzdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0cyBm b3IgdGhlIHdyaXRlYmFjayBlbmdpbmUKPiArICogQG5fZm9ybWF0czogTGVuZ3RoIG9mIHRoZSBm b3JtYXRzIGFycmF5Cj4gKyAqCj4gKyAqIFRoaXMgZnVuY3Rpb24gY3JlYXRlcyB0aGUgd3JpdGVi YWNrLWNvbm5lY3Rvci1zcGVjaWZpYyBwcm9wZXJ0aWVzIGlmIHRoZXkKPiArICogaGF2ZSBub3Qg YmVlbiBhbHJlYWR5IGNyZWF0ZWQsIGluaXRpYWxpemVzIHRoZSBjb25uZWN0b3IgYXMKPiArICog dHlwZSBEUk1fTU9ERV9DT05ORUNUT1JfV1JJVEVCQUNLLCBhbmQgY29ycmVjdGx5IGluaXRpYWxp emVzIHRoZSBwcm9wZXJ0eQo+ICsgKiB2YWx1ZXMuCj4gKyAqCj4gKyAqIERyaXZlcnMgc2hvdWxk IGFsd2F5cyB1c2UgdGhpcyBmdW5jdGlvbiBpbnN0ZWFkIG9mIGRybV9jb25uZWN0b3JfaW5pdCgp IHRvCj4gKyAqIHNldCB1cCB3cml0ZWJhY2sgY29ubmVjdG9ycy4KPiArICoKPiArICogUmV0dXJu czogMCBvbiBzdWNjZXNzLCBvciBhIG5lZ2F0aXZlIGVycm9yIGNvZGUKPiArICovCj4gK2ludCBk cm1fd3JpdGViYWNrX2Nvbm5lY3Rvcl9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJ CQkgc3RydWN0IGRybV93cml0ZWJhY2tfY29ubmVjdG9yICp3Yl9jb25uZWN0b3IsCj4gKwkJCQkg Y29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3JfZnVuY3MgKmZ1bmNzLAo+ICsJCQkJIHUzMiAqZm9y bWF0cywgaW50IG5fZm9ybWF0cykKClRoaXMgc2hvdWxkIHByb2JhYmx5IGJlICdjb25zdCB1MzIg KmZvcm1hdHMnLCBzaW5jZSBkZXZlbG9wZXJzIGFyZQpsaWtlbHkgdG8gZGVmaW5lIGEgdGhpcyBh cnJheSB3aXRoIGEgJ3N0YXRpYyBjb25zdCcgc3BlY2lmaWVyIGluIHRoZWlyCmRyaXZlci4KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:54064 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbdEEIWX (ORCPT ); Fri, 5 May 2017 04:22:23 -0400 Date: Fri, 5 May 2017 10:22:19 +0200 From: Boris Brezillon To: Brian Starkey Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, liviu.dudau@arm.com, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org Subject: Re: [PATCH 1/6] drm: Add writeback connector type Message-ID: <20170505102219.0ed543d2@bbrezillon> In-Reply-To: <1480092544-1725-2-git-send-email-brian.starkey@arm.com> References: <1480092544-1725-1-git-send-email-brian.starkey@arm.com> <1480092544-1725-2-git-send-email-brian.starkey@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, 25 Nov 2016 16:48:59 +0000 Brian Starkey wrote: > +/** > + * drm_writeback_connector_init - Initialize a writeback connector and its properties > + * @dev: DRM device > + * @wb_connector: Writeback connector to initialize > + * @funcs: Connector funcs vtable > + * @formats: Array of supported pixel formats for the writeback engine > + * @n_formats: Length of the formats array > + * > + * This function creates the writeback-connector-specific properties if they > + * have not been already created, initializes the connector as > + * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the property > + * values. > + * > + * Drivers should always use this function instead of drm_connector_init() to > + * set up writeback connectors. > + * > + * Returns: 0 on success, or a negative error code > + */ > +int drm_writeback_connector_init(struct drm_device *dev, > + struct drm_writeback_connector *wb_connector, > + const struct drm_connector_funcs *funcs, > + u32 *formats, int n_formats) This should probably be 'const u32 *formats', since developers are likely to define a this array with a 'static const' specifier in their driver.