From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Date: Fri, 5 May 2017 10:26:36 -0700 Message-ID: <20170505172636.GA128305@google.com> References: <20170420215605.176722-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170420215605.176722-1-mka@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Jani Nikula , David Airlie Cc: Grant Grundler , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Greg Hackmann , Michael Davidson , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org RWwgVGh1LCBBcHIgMjAsIDIwMTcgYXQgMDI6NTY6MDVQTSAtMDcwMCBNYXR0aGlhcyBLYWVobGNr ZSBoYSBkaXQ6Cgo+IEluIHNldmVyYWwgaW5zdGFuY2VzIHRoZSBkcml2ZXIgcGFzc2VzIGFuICdl bnVtIHBpcGUnIHZhbHVlIHRvIGEKPiBmdW5jdGlvbiBleHBlY3RpbmcgYW4gJ2VudW0gdHJhbnNj b2RlcicgYW5kIHZpY2V2ZXJzYS4gU2luY2UgUElQRV94IGFuZAo+IFRSQU5TQ09ERVJfeCBoYXZl IHRoZSBzYW1lIHZhbHVlcyB0aGlzIGRvZXNuJ3QgY2F1c2UgZnVuY3Rpb25hbAo+IHByb2JsZW1z LiBTdGlsbCBpdCBpcyBpbmNvcnJlY3QgYW5kIGNhdXNlcyBjbGFuZyB0byBnZW5lcmF0ZSB3YXJu aW5ncwo+IGxpa2UgdGhpczoKPiAKPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmM6MTg0NDozNDogd2FybmluZzogaW1wbGljaXQKPiAgIGNvbnZlcnNpb24gZnJvbSBlbnVtZXJh dGlvbiB0eXBlICdlbnVtIHRyYW5zY29kZXInIHRvIGRpZmZlcmVudAo+ICAgZW51bWVyYXRpb24g dHlwZSAnZW51bSBwaXBlJyBbLVdlbnVtLWNvbnZlcnNpb25dCj4gICAgIGFzc2VydF9mZGlfcnhf ZW5hYmxlZChkZXZfcHJpdiwgVFJBTlNDT0RFUl9BKTsKPiAKPiBDaGFuZ2UgdGhlIGNvZGUgdG8g cGFzcyB2YWx1ZXMgb2YgdGhlIHR5cGUgZXhwZWN0ZWQgYnkgdGhlIGNhbGxlZS4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBNYXR0aGlhcyBLYWVobGNrZSA8bWthQGNocm9taXVtLm9yZz4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNCArKy0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgICB8IDYgKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2hkbWkuYyAgICB8IDYgKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Nkdm8uYyAgICB8IDYgKysrKy0tCj4gIDQgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0 aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKClBpbmcsIGFueSBjb21tZW50cyBvbiB0aGlzIHBhdGNo PwoKKGFsc28gZXhjdXNlcyBmb3IgdGhlIHVuaW50ZW5kZWQgdXNlIG9mIHRoZSBSRVNFTkQgdGFn KQoKQ2hlZXJzCgpNYXR0aGlhcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750903AbdEER0k (ORCPT ); Fri, 5 May 2017 13:26:40 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:33859 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbdEER0j (ORCPT ); Fri, 5 May 2017 13:26:39 -0400 Date: Fri, 5 May 2017 10:26:36 -0700 From: Matthias Kaehlcke To: Daniel Vetter , Jani Nikula , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Grant Grundler , Greg Hackmann , Michael Davidson Subject: Re: [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Message-ID: <20170505172636.GA128305@google.com> References: <20170420215605.176722-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170420215605.176722-1-mka@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > In several instances the driver passes an 'enum pipe' value to a > function expecting an 'enum transcoder' and viceversa. Since PIPE_x and > TRANSCODER_x have the same values this doesn't cause functional > problems. Still it is incorrect and causes clang to generate warnings > like this: > > drivers/gpu/drm/i915/intel_display.c:1844:34: warning: implicit > conversion from enumeration type 'enum transcoder' to different > enumeration type 'enum pipe' [-Wenum-conversion] > assert_fdi_rx_enabled(dev_priv, TRANSCODER_A); > > Change the code to pass values of the type expected by the callee. > > Signed-off-by: Matthias Kaehlcke > --- > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > drivers/gpu/drm/i915/intel_dp.c | 6 ++++-- > drivers/gpu/drm/i915/intel_hdmi.c | 6 ++++-- > drivers/gpu/drm/i915/intel_sdvo.c | 6 ++++-- > 4 files changed, 14 insertions(+), 8 deletions(-) Ping, any comments on this patch? (also excuses for the unintended use of the RESEND tag) Cheers Matthias