From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:55396 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbdEER5x (ORCPT ); Fri, 5 May 2017 13:57:53 -0400 Date: Fri, 5 May 2017 10:57:44 -0700 From: Greg Kroah-Hartman To: Eric Biggers Cc: stable@vger.kernel.org, Richard Weinberger , Theodore Ts'o , Eric Biggers Subject: Re: [PATCH] ext4: require encryption feature for EXT4_IOC_SET_ENCRYPTION_POLICY Message-ID: <20170505175744.GA12923@kroah.com> References: <20170502211532.33611-1-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170502211532.33611-1-ebiggers3@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, May 02, 2017 at 02:15:32PM -0700, Eric Biggers wrote: > From: Richard Weinberger > > commit 9a200d075e5d05be1fcad4547a0f8aee4e2f9a04 upstream. Please apply > to 4.4-stable. (Having to make this change is unfortunate since it > could break some users of ext4 encryption, but we haven't received any > complaints about this being in the 4.9 kernel, and we need to do this > because otherwise anyone who can write to an ext4 filesystem with > block_size != PAGE_SIZE can crash the kernel or corrupt the filesystem.) > > ...otherwise an user can enable encryption for certain files even > when the filesystem is unable to support it. > Such a case would be a filesystem created by mkfs.ext4's default > settings, 1KiB block size. Ext4 supports encyption only when block size > is equal to PAGE_SIZE. > But this constraint is only checked when the encryption feature flag > is set. > > Signed-off-by: Richard Weinberger > Signed-off-by: Theodore Ts'o > Signed-off-by: Eric Biggers > --- > fs/ext4/ioctl.c | 3 +++ > 1 file changed, 3 insertions(+) This was for 4.4, right? Now queued up there. greg k-h