From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 15/15] drm/i915: Simplify cursor register write sequence Date: Sat, 6 May 2017 00:31:50 +0300 Message-ID: <20170505213150.GD24641@ideak-desk.fi.intel.com> References: <20170327185546.2977-1-ville.syrjala@linux.intel.com> <20170327185546.2977-16-ville.syrjala@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77B916E6D0 for ; Fri, 5 May 2017 21:31:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170327185546.2977-16-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMjcsIDIwMTcgYXQgMDk6NTU6NDZQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBJdCBsb29rcyBsaWtlIHNpbXBseSB3cml0aW5nIGFs bCB0aGUgY3Vyc29yIHJlZ2lzdGVyIGV2ZXJ5IHNpbmdsZQo+IHRpbWUgbWlnaHQgYmUgc2xpZ2h0 bHkgZmFzdGVyIHRoYW4gY2hlY2tpbmcgdG8gc2VlIG9mIGVhY2ggb2YKPiB0aGVtIG5lZWQgdG8g YmUgd3JpdHRlbi4gU28gaWYgYW55IG90aGVyIHJlZ2lzdGVyIGFwYXJ0IGZyb20KPiBDVVJQT1Mg bmVlZHMgdG8gYmUgd3JpdHRlbiBsZXQncyBqdXN0IHdyaXRlIGFsbCB0aGUgcmVnaXN0ZXJzLgo+ IAo+IENVUlBPUyBpcyBsZWZ0IGFzIGEgc3BlY2lhbCBjYXNlIG1haW5seSBmb3IgODQ1Lzg2NSB3 aGVyZSB3ZSBoYXZlIHRvCj4gZGlzYWJsZSB0aGUgY3Vyc29yIHRvIGNoYW5nZSBtYW55IG9mIHRo ZSBjdXJzb3IgcGFyYW1ldGVycy4gVGhpcwo+IGludHJvZHVjZXMgYSBzbGlnaHQgY2hhbmNlIG9m IHRoZSBjdXJzb3IgZmxpY2tlcmluZyB3aGVuIHRoaW5ncyBnZXQKPiB1cGRhdGVkIChzaW5jZSB3 ZSdyZSBub3QgY3VycmVudGx5IGRvaW5nIHRoZSB2YmxhbmsgZXZhZGUgZm9yIGN1cnNvcgo+IHVw ZGF0ZXMpLiBJZiB3ZSB3cml0ZSBDVVJQT1MgYWxvbmUgdGhlbiB0aGF0IG9idmlvdXNseSBjYW4n dCBoYXBwZW4uCj4gQW5kIGxldCdzIGZvbGxvdyB0aGUgc2FtZSBwYXR0ZXJuIGluIHRoZSBpOXh4 IGNvZGUganVzdCBmb3Igc3ltbWV0cnkuCj4gSSB3YXNuJ3QgYWJsZSB0byBzZWUgYSBzaW5naWZp Y2FudCBwZXJmb3JtYW5jZSBkaWZmZXJlbmNlIGJldHdlZW4KPiB0aGlzIGFuZCBqdXN0IHdyaXRp bmcgYWxsIHRoZSByZWdpc3RlcnMgdW5jb25kaXRpb25hbGx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdl ZC1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNjkgKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAzNSBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZDc4 YWIwZDM1Mjc0Li40MGFjMGY5MzhhNGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gQEAgLTkzMjMsMzYgKzkzMjMsMjggQEAgc3RhdGljIHZvaWQgaTg0NV91cGRhdGVf Y3Vyc29yKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gIAo+ICAJc3Bpbl9sb2NrX2lycXNh dmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+ICAKPiAtCWlmIChwbGFuZS0+ Y3Vyc29yLmNudGwgIT0gMCAmJgo+IC0JICAgIChwbGFuZS0+Y3Vyc29yLmJhc2UgIT0gYmFzZSB8 fAo+IC0JICAgICBwbGFuZS0+Y3Vyc29yLnNpemUgIT0gc2l6ZSB8fAo+IC0JICAgICBwbGFuZS0+ Y3Vyc29yLmNudGwgIT0gY250bCkpIHsKPiAtCQkvKiBPbiB0aGVzZSBjaGlwc2V0cyB3ZSBjYW4g b25seSBtb2RpZnkgdGhlIGJhc2Uvc2l6ZS9zdHJpZGUKPiAtCQkgKiB3aGlsc3QgdGhlIGN1cnNv ciBpcyBkaXNhYmxlZC4KPiAtCQkgKi8KPiArCS8qIE9uIHRoZXNlIGNoaXBzZXRzIHdlIGNhbiBv bmx5IG1vZGlmeSB0aGUgYmFzZS9zaXplL3N0cmlkZQo+ICsJICogd2hpbHN0IHRoZSBjdXJzb3Ig aXMgZGlzYWJsZWQuCj4gKwkgKi8KPiArCWlmIChwbGFuZS0+Y3Vyc29yLmJhc2UgIT0gYmFzZSB8 fAo+ICsJICAgIHBsYW5lLT5jdXJzb3Iuc2l6ZSAhPSBzaXplIHx8Cj4gKwkgICAgcGxhbmUtPmN1 cnNvci5jbnRsICE9IGNudGwpIHsKPiAgCQlJOTE1X1dSSVRFX0ZXKENVUkNOVFIoUElQRV9BKSwg MCk7Cj4gLQkJcGxhbmUtPmN1cnNvci5jbnRsID0gMDsKPiAtCX0KPiAtCj4gLQlpZiAocGxhbmUt PmN1cnNvci5iYXNlICE9IGJhc2UpCj4gIAkJSTkxNV9XUklURV9GVyhDVVJCQVNFKFBJUEVfQSks IGJhc2UpOwo+IC0KPiAtCWlmIChwbGFuZS0+Y3Vyc29yLnNpemUgIT0gc2l6ZSkKPiAgCQlJOTE1 X1dSSVRFX0ZXKENVUlNJWkUsIHNpemUpOwo+IC0KPiAtCWlmIChjbnRsKQo+ICAJCUk5MTVfV1JJ VEVfRlcoQ1VSUE9TKFBJUEVfQSksIHBvcyk7Cj4gLQo+IC0JaWYgKHBsYW5lLT5jdXJzb3IuY250 bCAhPSBjbnRsKQo+ICAJCUk5MTVfV1JJVEVfRlcoQ1VSQ05UUihQSVBFX0EpLCBjbnRsKTsKPiAg Cj4gKwkJcGxhbmUtPmN1cnNvci5iYXNlID0gYmFzZTsKPiArCQlwbGFuZS0+Y3Vyc29yLnNpemUg PSBzaXplOwo+ICsJCXBsYW5lLT5jdXJzb3IuY250bCA9IGNudGw7Cj4gKwl9IGVsc2Ugewo+ICsJ CUk5MTVfV1JJVEVfRlcoQ1VSUE9TKFBJUEVfQSksIHBvcyk7Cj4gKwl9Cj4gKwo+ICAJUE9TVElO R19SRUFEX0ZXKENVUkNOVFIoUElQRV9BKSk7Cj4gIAo+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9y ZSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gLQo+IC0JcGxhbmUtPmN1cnNv ci5jbnRsID0gY250bDsKPiAtCXBsYW5lLT5jdXJzb3IuYmFzZSA9IGJhc2U7Cj4gLQlwbGFuZS0+ Y3Vyc29yLnNpemUgPSBzaXplOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBpODQ1X2Rpc2FibGVf Y3Vyc29yKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gQEAgLTk1MDgsMjcgKzk1MDAsMzQg QEAgc3RhdGljIHZvaWQgaTl4eF91cGRhdGVfY3Vyc29yKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxh bmUsCj4gIAo+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJx ZmxhZ3MpOwo+ICAKPiAtCWlmIChwbGFuZS0+Y3Vyc29yLmNudGwgIT0gY250bCkKPiArCS8qCj4g KwkgKiBPbiBzb21lIHBsYXRmb3JtcyB3cml0aW5nIENVUkNOVFIgZmlyc3Qgd2lsbCBhbHNvCj4g KwkgKiBjYXVzZSBDVVJQT1MgdG8gYmUgYXJtZWQgYnkgdGhlIENVUkJBU0Ugd3JpdGUuCj4gKwkg KiBXaXRob3V0IHRoZSBDVVJDTlRSIHdyaXRlIHRoZSBDVVJQT1Mgd3JpdGUgd291bGQKPiArCSAq IGFybSBpdHNlbGYuCj4gKwkgKgo+ICsJICogQ1VSQ05UUiBhbmQgQ1VSX0ZCQ19DVEwgYXJlIGFs d2F5cwo+ICsJICogYXJtZWQgYnkgdGhlIENVUkJBU0Ugd3JpdGUgb25seS4KPiArCSAqLwo+ICsJ aWYgKHBsYW5lLT5jdXJzb3IuYmFzZSAhPSBiYXNlIHx8Cj4gKwkgICAgcGxhbmUtPmN1cnNvci5z aXplICE9IGZiY19jdGwgfHwKPiArCSAgICBwbGFuZS0+Y3Vyc29yLmNudGwgIT0gY250bCkgewo+ ICAJCUk5MTVfV1JJVEVfRlcoQ1VSQ05UUihwaXBlKSwgY250bCk7Cj4gLQo+IC0JaWYgKHBsYW5l LT5jdXJzb3Iuc2l6ZSAhPSBmYmNfY3RsKQo+IC0JCUk5MTVfV1JJVEVfRlcoQ1VSX0ZCQ19DVEwo cGlwZSksIGZiY19jdGwpOwo+IC0KPiAtCWlmIChjbnRsKQo+ICsJCWlmIChIQVNfQ1VSX0ZCQyhk ZXZfcHJpdikpCj4gKwkJCUk5MTVfV1JJVEVfRlcoQ1VSX0ZCQ19DVEwocGlwZSksIGZiY19jdGwp Owo+ICAJCUk5MTVfV1JJVEVfRlcoQ1VSUE9TKHBpcGUpLCBwb3MpOwo+IC0KPiAtCWlmIChwbGFu ZS0+Y3Vyc29yLmNudGwgIT0gY250bCB8fAo+IC0JICAgIHBsYW5lLT5jdXJzb3Iuc2l6ZSAhPSBm YmNfY3RsIHx8Cj4gLQkgICAgcGxhbmUtPmN1cnNvci5iYXNlICE9IGJhc2UpCj4gIAkJSTkxNV9X UklURV9GVyhDVVJCQVNFKHBpcGUpLCBiYXNlKTsKPiAgCj4gKwkJcGxhbmUtPmN1cnNvci5iYXNl ID0gYmFzZTsKPiArCQlwbGFuZS0+Y3Vyc29yLnNpemUgPSBmYmNfY3RsOwo+ICsJCXBsYW5lLT5j dXJzb3IuY250bCA9IGNudGw7Cj4gKwl9IGVsc2Ugewo+ICsJCUk5MTVfV1JJVEVfRlcoQ1VSUE9T KHBpcGUpLCBwb3MpOwo+ICsJfQo+ICsKPiAgCVBPU1RJTkdfUkVBRF9GVyhDVVJCQVNFKHBpcGUp KTsKPiAgCj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ss IGlycWZsYWdzKTsKPiAtCj4gLQlwbGFuZS0+Y3Vyc29yLmNudGwgPSBjbnRsOwo+IC0JcGxhbmUt PmN1cnNvci5iYXNlID0gYmFzZTsKPiAtCXBsYW5lLT5jdXJzb3Iuc2l6ZSA9IGZiY19jdGw7Cj4g IH0KPiAgCj4gIHN0YXRpYyB2b2lkIGk5eHhfZGlzYWJsZV9jdXJzb3Ioc3RydWN0IGludGVsX3Bs YW5lICpwbGFuZSwKPiAtLSAKPiAyLjEwLjIKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==