From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Date: Sat, 06 May 2017 14:45:19 +0000 Subject: Re: [PATCH] net: dsa: loop: Check for memory allocation failure Message-Id: <20170506144519.GA23180@lunn.ch> List-Id: References: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, May 06, 2017 at 07:29:45AM +0200, Christophe JAILLET wrote: > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for some other memory allocation just a > few lines above. > > Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") > > Signed-off-by: Christophe JAILLET Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752996AbdEFOpb (ORCPT ); Sat, 6 May 2017 10:45:31 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:52017 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbdEFOpX (ORCPT ); Sat, 6 May 2017 10:45:23 -0400 Date: Sat, 6 May 2017 16:45:19 +0200 From: Andrew Lunn To: Christophe JAILLET Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net: dsa: loop: Check for memory allocation failure Message-ID: <20170506144519.GA23180@lunn.ch> References: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 06, 2017 at 07:29:45AM +0200, Christophe JAILLET wrote: > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for some other memory allocation just a > few lines above. > > Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") > > Signed-off-by: Christophe JAILLET Reviewed-by: Andrew Lunn Andrew