From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH 0/4 v2] mm,dax: Fix data corruption due to mmap inconsistency Date: Mon, 8 May 2017 11:27:07 -0600 Message-ID: <20170508172707.GB18408@linux.intel.com> References: <20170505072500.25692-1-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20170505072500.25692-1-jack-AlSwsSmVLrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Fri, May 05, 2017 at 09:24:56AM +0200, Jan Kara wrote: > Hello, > > this series fixes data corruption that can happen for DAX mounts when > page faults race with write(2) and as a result page tables get out of sync > with block mappings in the filesystem and thus data seen through mmap is > different from data seen through read(2). > > The series passes testing with t_mmap_stale test program from Ross and also > other mmap related tests on DAX filesystem. Ross, what you think? I don't know if I have enough ext4-fu to properly review patch 3, but the rest looks great (and that patch looks good to me as well, FWIW). Thanks for fixing this! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 226FD21A0BAA1 for ; Mon, 8 May 2017 10:27:09 -0700 (PDT) Date: Mon, 8 May 2017 11:27:07 -0600 From: Ross Zwisler Subject: Re: [PATCH 0/4 v2] mm,dax: Fix data corruption due to mmap inconsistency Message-ID: <20170508172707.GB18408@linux.intel.com> References: <20170505072500.25692-1-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170505072500.25692-1-jack@suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jan Kara Cc: Andrew Morton , linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org List-ID: On Fri, May 05, 2017 at 09:24:56AM +0200, Jan Kara wrote: > Hello, > > this series fixes data corruption that can happen for DAX mounts when > page faults race with write(2) and as a result page tables get out of sync > with block mappings in the filesystem and thus data seen through mmap is > different from data seen through read(2). > > The series passes testing with t_mmap_stale test program from Ross and also > other mmap related tests on DAX filesystem. Ross, what you think? I don't know if I have enough ext4-fu to properly review patch 3, but the rest looks great (and that patch looks good to me as well, FWIW). Thanks for fixing this! _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:58419 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbdEHR1L (ORCPT ); Mon, 8 May 2017 13:27:11 -0400 Date: Mon, 8 May 2017 11:27:07 -0600 From: Ross Zwisler To: Jan Kara Cc: Ross Zwisler , Andrew Morton , Dan Williams , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org Subject: Re: [PATCH 0/4 v2] mm,dax: Fix data corruption due to mmap inconsistency Message-ID: <20170508172707.GB18408@linux.intel.com> References: <20170505072500.25692-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170505072500.25692-1-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 05, 2017 at 09:24:56AM +0200, Jan Kara wrote: > Hello, > > this series fixes data corruption that can happen for DAX mounts when > page faults race with write(2) and as a result page tables get out of sync > with block mappings in the filesystem and thus data seen through mmap is > different from data seen through read(2). > > The series passes testing with t_mmap_stale test program from Ross and also > other mmap related tests on DAX filesystem. Ross, what you think? I don't know if I have enough ext4-fu to properly review patch 3, but the rest looks great (and that patch looks good to me as well, FWIW). Thanks for fixing this!