From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] netlink_delinearize: don't kill dependencies accross statements
Date: Mon, 8 May 2017 19:56:57 +0200 [thread overview]
Message-ID: <20170508175657.GA7955@salvia> (raw)
In-Reply-To: <20170508081750.28093-1-fw@strlen.de>
On Mon, May 08, 2017 at 10:17:50AM +0200, Florian Westphal wrote:
> nft currently translates
> ip protocol tcp meta mark set 1 tcp dport 22
> to
> mark set 0x00000001 tcp dport 22
>
> This is wrong, the latter form is same as
>
> mark set 0x00000001 ip protocol tcp tcp dport 22
>
> and thats not correct (original rule sets mark for tcp packets only).
>
> We need to clear the dependency stack whenever we see a statement other
> than stmt_expr, as these will have side effects (counter, payload
> mangling, logging and the like).
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Could you add a test for this? Thanks.
next prev parent reply other threads:[~2017-05-08 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 8:17 [PATCH nft] netlink_delinearize: don't kill dependencies accross statements Florian Westphal
2017-05-08 17:56 ` Pablo Neira Ayuso [this message]
2017-05-08 19:54 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508175657.GA7955@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.