All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
	Richard Guy Briggs <rgb@redhat.com>,
	fwestpha@redhat.com,
	netfilter-devel <netfilter-devel@vger.kernel.org>,
	pmoore@redhat.com, pvrabec@redhat.com
Subject: Re: .config for iptables icmp rule delete failure
Date: Tue, 9 May 2017 04:32:00 +0200	[thread overview]
Message-ID: <20170509023200.GA16263@breakpoint.cc> (raw)
In-Reply-To: <CA+FuTSdikLZoOZDXLPG933DP6sBzqSU0s9DE7L+3Y4xMquK3fQ@mail.gmail.com>

Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:

> Thanks, Florian. Also for the detailed context. I'm having a look.
> The following might be sufficient. It fixes the given example for me.
> 
> @@ -288,6 +288,10 @@ int xt_data_to_user(void __user *dst, const void *src,
>         usersize = usersize ? : size;
>         if (copy_to_user(dst, src, usersize))
>                 return -EFAULT;
> +       size = XT_ALIGN(size);
>         if (usersize != size && clear_user(dst + usersize, size - usersize))
>                 return -EFAULT;

Looks good, but I think this needs a tweak for compat case (use of
COMPAT_XT_ALIGN()).

  reply	other threads:[~2017-05-09  2:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-07 20:43 .config for iptables icmp rule delete failure Richard Guy Briggs
2017-05-08 20:22 ` Florian Westphal
2017-05-09  2:22   ` Willem de Bruijn
2017-05-09  2:32     ` Florian Westphal [this message]
2017-05-09  4:18     ` Willem de Bruijn
2017-05-09  4:47       ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170509023200.GA16263@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=fwestpha@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pmoore@redhat.com \
    --cc=pvrabec@redhat.com \
    --cc=rgb@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.