From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Support srccode output
Date: Tue, 9 May 2017 11:06:31 +0200 [thread overview]
Message-ID: <20170509090631.GB4031@krava> (raw)
In-Reply-To: <20170508202205.28520-1-andi@firstfloor.org>
On Mon, May 08, 2017 at 01:22:05PM -0700, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
> index df051a52393c..542bfa7db53c 100644
> --- a/tools/perf/util/srcline.c
> +++ b/tools/perf/util/srcline.c
> @@ -479,6 +479,35 @@ char *__get_srcline(struct dso *dso, u64 addr, struct symbol *sym,
> return srcline;
> }
>
> +/* Returns filename and fills in line number in line */
> +char *get_srcline_split(struct dso *dso, u64 addr,
> + bool unwind_inlines, unsigned *line)
no need to pass unwind_inlines as arg if it's always true
jirka
next prev parent reply other threads:[~2017-05-09 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 20:22 [PATCH] perf, tools: Support srccode output Andi Kleen
2017-05-09 9:05 ` Jiri Olsa
2017-05-09 9:06 ` Jiri Olsa [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-04 0:18 Andi Kleen
2018-12-05 12:28 ` Jiri Olsa
2018-12-05 16:54 ` Arnaldo Carvalho de Melo
2018-12-05 17:05 ` Jiri Olsa
2018-12-05 17:33 ` Andi Kleen
2018-12-05 22:15 ` Arnaldo Carvalho de Melo
2017-05-09 12:06 Andi Kleen
2017-05-09 12:36 ` Jiri Olsa
2017-05-05 23:00 Andi Kleen
2017-05-07 14:45 ` Jiri Olsa
2017-05-07 15:29 ` Andi Kleen
2017-05-07 14:45 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509090631.GB4031@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.