From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: liam.r.girdwood@linux.intel.com, Naveen M <naveen.m@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
pierre-louis.bossart@intel.com
Subject: Re: [PATCH 3/6] ASoC: Add quirk data to support multiple codecs
Date: Tue, 9 May 2017 15:56:23 +0530 [thread overview]
Message-ID: <20170509102623.GS6263@localhost> (raw)
In-Reply-To: <s5h7f1q8sfw.wl-tiwai@suse.de>
On Tue, May 09, 2017 at 08:17:39AM +0200, Takashi Iwai wrote:
> On Mon, 08 May 2017 11:18:57 +0200,
> Naveen M wrote:
> >
> > Add quirk data in sst_acpi_mach() which will hold number of codecs
> > and codec names to search for a best possible matching machine.
> > Set NULL for existing drivers not using this.
>
> It's better to rewrite the existing code with C99 style
> initialization before introducing such a new field. For the atom
> driver, it's more better with some macros to simplify.
> Then you don't have to touch the code as long as the default value is
> zero.
Agreed and it is more readable as well, we will change this :)
--
~Vinod
next prev parent reply other threads:[~2017-05-09 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 9:18 [PATCH 0/6] ASoC: Intel: kabylake: Adds rt5663+max98927 machine driver Naveen M
2017-05-08 9:18 ` [PATCH 1/6] ASoC: Intel: Create a helper to search for matching machine Naveen M
2017-05-24 17:41 ` Applied "ASoC: Intel: Create a helper to search for matching machine" to the asoc tree Mark Brown
2017-05-08 9:18 ` [PATCH 2/6] ASoC: Move quirk to identify correct machine driver Naveen M
2017-05-24 17:41 ` Applied "ASoC: Move quirk to identify correct machine driver" to the asoc tree Mark Brown
2017-05-08 9:18 ` [PATCH 3/6] ASoC: Add quirk data to support multiple codecs Naveen M
2017-05-09 6:17 ` Takashi Iwai
2017-05-09 10:26 ` Vinod Koul [this message]
2017-05-08 9:18 ` [PATCH 4/6] ASoC: Improve machine driver selection based on quirk data Naveen M
2017-05-08 9:18 ` [PATCH 5/6] ASoC: Intel: Add Kabylake Realtek Maxim machine driver Naveen M
2017-05-24 17:41 ` Applied "ASoC: Intel: Add Kabylake Realtek Maxim machine driver" to the asoc tree Mark Brown
2017-05-08 9:19 ` [PATCH 6/6] ASoC: Intel: Add Kabylake RT5663+MAX98927 machine driver entry Naveen M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509102623.GS6263@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=naveen.m@intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.