Re: [Qemu-devel] [PATCH 0/5] 9pfs: local: fix metadata of mapped-file security mode

[Greg Kurz <groug@kaod.org>]

[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]

On Mon, 8 May 2017 17:33:43 +0200
Leo Gaspard <leo@gaspard.io> wrote:

> Greg,
> 
> I just tested on 2.9.0 with the 5 patches applied, and it appears to
> work on my setup, thanks!
> 
> Just a side note: .virtfs_metadata_root is set as u=rwx on the host file
> system (the "ret = fchmod(map_fd, 0700);" line in patch 4 I guess),
> while u=rw would be more appropriate, I think.
> 

You're right. I'll change that.

> Thank you,
> Leo
> 
> 
> On 05/05/2017 04:36 PM, Greg Kurz wrote:
> > This series fixes two issues in the local backend when using the mapped-file
> > security mode:
> > - allow chmod and chown to succeed on the virtfs root (patch 4)
> > - completely hide the metadata files from the client (patch 5)
> > 
> > Patch 2 resolves '.' and '..' in paths, and patch 3 reworks the way we open
> > files accordingly. They could be squashed together in a single patch (this
> > was the case in earlier versions actually), but I decided to separate them
> > for easier review.
> > 
> > Léo,
> > 
> > I'd appreciate if you could test this series (especially patch 4) on your
> > setup.
> > 
> > Cheers.
> > 
> > --
> > Greg
> > 
> > ---
> > 
> > Greg Kurz (5):
> >       9pfs: check return value of v9fs_co_name_to_path()
> >       9pfs: local: resolve special directories in paths
> >       9pfs: local: simplify file opening
> >       9pfs: local: metadata file for the VirtFS root
> >       9pfs: local: forbid client access to metadata
> > 
> > 
> >  hw/9pfs/9p-local.c |  164 ++++++++++++++++++++++++++++++++++++++++------------
> >  hw/9pfs/9p-util.c  |   26 +++-----
> >  hw/9pfs/9p.c       |   36 ++++++++---
> >  3 files changed, 160 insertions(+), 66 deletions(-)
> >   
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]